switch to sysseek + sysread for serving static files

The "perlio" layer doesn't do read(2) syscalls over 8192 bytes
at the moment, and binmode($fh, ':unix') leaks[1].  So use
sysseek and sysread for now, since I can't see retaining
compatibility with PerlIO::scalar being worth the trouble.

[1] http://nntp.perl.org/group/perl.perl5.porters/256918

diff --git a/lib/PublicInbox/DS.pm b/lib/PublicInbox/DS.pm
index c76a5038354c2d846bef2ccb5a3f3754ba5de486..4d685131f0cf24ec709f878d518ccdfa64eecdae 100644 (file)
--- a/lib/PublicInbox/DS.pm
+++ b/lib/PublicInbox/DS.pm
@@ -395,10 +395,10 @@ sub close {
 sub send_tmpio ($$) {
     my ($sock, $tmpio) = @_;
 
-    seek($tmpio->[0], $tmpio->[1], SEEK_SET) or return;
+    sysseek($tmpio->[0], $tmpio->[1], SEEK_SET) or return;
     my $n = $tmpio->[2] // 65536;
     $n = 65536 if $n > 65536;
-    defined(my $to_write = read($tmpio->[0], my $buf, $n)) or return;
+    defined(my $to_write = sysread($tmpio->[0], my $buf, $n)) or return;
     my $written = 0;
     while ($to_write > 0) {
         if (defined(my $w = syswrite($sock, $buf, $to_write, $written))) {

diff --git a/lib/PublicInbox/WwwStatic.pm b/lib/PublicInbox/WwwStatic.pm
index 60a71d8d20f007eaa150e7f22866df782c8c7761..547b75bba01c369d7caa75a07ac3ed1fcac9d28b 100644 (file)
--- a/lib/PublicInbox/WwwStatic.pm
+++ b/lib/PublicInbox/WwwStatic.pm
@@ -176,9 +176,9 @@ sub getline {
        my $len = $self->{len} or return; # undef, tells server we're done
        my $n = 8192;
        $n = $len if $len < $n;
-       seek($self->{in}, $self->{off}, SEEK_SET) or
-                       die "seek ($self->{path}): $!";
-       my $r = read($self->{in}, my $buf, $n);
+       sysseek($self->{in}, $self->{off}, SEEK_SET) or
+                       die "sysseek ($self->{path}): $!";
+       my $r = sysread($self->{in}, my $buf, $n);
        if (defined $r && $r > 0) { # success!
                $self->{len} = $len - $r;
                $self->{off} += $r;