From: Eric Wong <e@80x24.org>
Date: Tue, 9 May 2017 06:30:41 +0000 (+0000)
Subject: searchidx: use cached local $@ copy
X-Git-Tag: v1.0.0~69
X-Git-Url: http://www.git.stargrave.org/?p=public-inbox.git;a=commitdiff_plain;h=1c9be46742295e943f7d919ee01ecbf134cbf493

searchidx: use cached local $@ copy

umask should never fail and set $@, but use the cached local
to be more explicit just in case.
---

diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm
index e4e3c81b..fd0d320e 100644
--- a/lib/PublicInbox/SearchIdx.pm
+++ b/lib/PublicInbox/SearchIdx.pm
@@ -620,7 +620,7 @@ sub with_umask {
 	my $rv = eval { $cb->() };
 	my $err = $@;
 	umask $old;
-	die $err if $@;
+	die $err if $err;
 	$rv;
 }