From: Eric Wong <e@yhbt.net>
Date: Wed, 6 May 2020 00:40:45 +0000 (+0000)
Subject: git: warn on ->cat_async callback errors
X-Git-Tag: v1.5.0~26
X-Git-Url: http://www.git.stargrave.org/?p=public-inbox.git;a=commitdiff_plain;h=2e168e869df3f1ca88f2eb22a8d1a1dda869b6ef

git: warn on ->cat_async callback errors

This will help us track down bugs in our own code when
it comes to missing error checking.
---

diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm
index 057135ef..8426cc7d 100644
--- a/lib/PublicInbox/Git.pm
+++ b/lib/PublicInbox/Git.pm
@@ -147,6 +147,7 @@ sub _cat_async_step ($$) {
 	my ($oid_hex, $type, $size) = ($1, $2, $3 + 0);
 	my $bref = read_cat_in_full($self, $size);
 	eval { $cb->($bref, $oid_hex, $type, $size, $arg) };
+	warn "E: $oid_hex $@\n" if $@;
 }
 
 sub cat_async_wait ($) {