From: Eric Wong <e@80x24.org>
Date: Sun, 8 May 2022 22:10:31 +0000 (+0000)
Subject: daemon: fix uninitialized variable
X-Git-Tag: v1.9.0~122
X-Git-Url: http://www.git.stargrave.org/?p=public-inbox.git;a=commitdiff_plain;h=37ee470e1f4a279171452418f013bf114bab343f

daemon: fix uninitialized variable

And also replace an unnecessary substitution (s///) op with a
match (m//).

Fixes: 93a7b219d58aad86 ("public-inbox-netd: a multi-protocol superserver")
---

diff --git a/lib/PublicInbox/Daemon.pm b/lib/PublicInbox/Daemon.pm
index 13cce1ec..d08ce0f9 100644
--- a/lib/PublicInbox/Daemon.pm
+++ b/lib/PublicInbox/Daemon.pm
@@ -618,9 +618,9 @@ sub daemon_loop ($) {
 	while (my ($k, $v) = each %tls_opt) {
 		my $l = $k;
 		$l =~ s!\A([^:]+)://!!;
-		my $scheme = $1;
+		my $scheme = $1 // '';
 		my $xn = $xnetd->{$l} // $xnetd->{''};
-		if ($scheme =~ s!\A(?:https|imaps|nntps)!!) {
+		if ($scheme =~ m!\A(?:https|imaps|nntps)!) {
 			$post_accept{$l} = tls_start_cb($v, $xn->{post_accept});
 		} elsif ($xn->{tlsd}) { # STARTTLS, $k eq '' is OK
 			$xn->{tlsd}->{accept_tls} = $v;