From: Eric Wong Date: Mon, 16 Aug 2021 23:35:20 +0000 (+0000) Subject: view: remove mbox.gz and Atom from topic view X-Git-Tag: v1.7.0~502 X-Git-Url: http://www.git.stargrave.org/?p=public-inbox.git;a=commitdiff_plain;h=38f2f94b97199f0f81fb93ab6d3c34651b661d6c view: remove mbox.gz and Atom from topic view This declutters the topic view since these links seem rarely used. Atom and mbox.gz links probably make most sense when users have read the HTML and decide the topic is worth following or downloading. Reported-by: Konstantin Ryabitsev Link: https://public-inbox.org/meta/20210816154444.sj3ks2sikq3x2ywx@nitro.local/ --- diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index c80a675e..17d38302 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -1154,10 +1154,8 @@ sub dump_topics { $anchor = '#t'; # thread skeleton } - my $mbox = qq(mbox.gz); - my $atom = qq(Atom); my $s = "$top_subj\n" . - " $ds UTC $n - $mbox / $atom\n"; + " $ds UTC $n\n"; for (my $i = 0; $i < scalar(@extra); $i += 2) { my $level = $extra[$i]; my $subj = $extra[$i + 1]; # already normalized diff --git a/t/psgi_bad_mids.t b/t/psgi_bad_mids.t index f92e4f97..8e531b54 100644 --- a/t/psgi_bad_mids.t +++ b/t/psgi_bad_mids.t @@ -53,7 +53,7 @@ test_psgi(sub { $www->call(@_) }, sub { ok(index($raw, $mid) < 0, "escaped $mid"); } - my (@xmids) = ($raw =~ m!\bhref="([^"]+)/t\.mbox\.gz"!sg); + my (@xmids) = ($raw =~ m!\bhref="([^"]+?)/T/#u"!sg); is(scalar(@xmids), scalar(@mids), 'got escaped links to all messages');