From: Eric Wong <e@80x24.org>
Date: Fri, 27 Nov 2020 09:52:52 +0000 (+0000)
Subject: nntp: some minor golfing
X-Git-Tag: v1.7.0~1604
X-Git-Url: http://www.git.stargrave.org/?p=public-inbox.git;a=commitdiff_plain;h=3e554f68b706c2f3dd985baf64abd6921a7d9bc2

nntp: some minor golfing

Reduce screen real estate usage to reduce human attention span
requirements.
---

diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index af40b86d..967a36a5 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -92,8 +92,7 @@ sub process_line ($$) {
 		err($self, 'error from: %s (%s)', $l, $err);
 		$res = '503 program fault - command not performed';
 	}
-	return 0 unless defined $res;
-	res($self, $res);
+	defined($res) ? res($self, $res) : 0;
 }
 
 # The keyword argument is not used (rfc3977 5.2.2)
@@ -109,9 +108,7 @@ sub cmd_capabilities ($;$) {
 
 sub cmd_mode ($$) {
 	my ($self, $arg) = @_;
-	$arg = uc $arg;
-	return r501 unless $arg eq 'READER';
-	'201 Posting prohibited';
+	uc($arg) eq 'READER' ? '201 Posting prohibited' : r501;
 }
 
 sub cmd_slave ($) { '202 slave status noted' }