From: Eric Wong <e@yhbt.net>
Date: Mon, 15 Jun 2020 09:17:28 +0000 (+0000)
Subject: imap: stop_idle: fix parameter parsing :x
X-Git-Tag: v1.6.0~375
X-Git-Url: http://www.git.stargrave.org/?p=public-inbox.git;a=commitdiff_plain;h=46595636f006ec8817b5626168c25310f4a67d43

imap: stop_idle: fix parameter parsing :x

stop_idle was a noop when the client issues a "DONE"
continuation or just disconnects.  This would not have
led to a long term memory leak since FDs get closed and
reused, anyways, and all of our InboxIdle mappings are
keyed by FD.
---

diff --git a/lib/PublicInbox/IMAP.pm b/lib/PublicInbox/IMAP.pm
index d4ef6efe..373bffc1 100644
--- a/lib/PublicInbox/IMAP.pm
+++ b/lib/PublicInbox/IMAP.pm
@@ -351,7 +351,7 @@ sub cmd_idle ($$) {
 }
 
 sub stop_idle ($$) {
-	my ($self, $ibx);
+	my ($self, $ibx) = @_;
 	my $sock = $self->{sock} or return;
 	my $fd = fileno($sock);
 	delete $IDLERS->{$fd};