From: Eric Wong <e@yhbt.net>
Date: Tue, 3 Mar 2020 09:50:57 +0000 (+0000)
Subject: spawn: correctly handle error code
X-Git-Tag: v1.4.0~90
X-Git-Url: http://www.git.stargrave.org/?p=public-inbox.git;a=commitdiff_plain;h=4de32cbee1bab278a15cd83e7c620de0d7777be5

spawn: correctly handle error code

Both the C and pure Perl implementions of `pi_fork_exec'
returns `-1' on error, not `undef'.
---

diff --git a/lib/PublicInbox/Spawn.pm b/lib/PublicInbox/Spawn.pm
index 2d9f734c..ad6be187 100644
--- a/lib/PublicInbox/Spawn.pm
+++ b/lib/PublicInbox/Spawn.pm
@@ -210,7 +210,7 @@ sub spawn ($;$$) {
 	}
 	my $cd = $opts->{'-C'} // ''; # undef => NULL mapping doesn't work?
 	my $pid = pi_fork_exec($redir, $f, $cmd, \@env, $rlim, $cd);
-	die "fork_exec failed: $!\n" unless defined $pid;
+	die "fork_exec failed: $!\n" unless $pid > 0;
 	$pid;
 }