From: Eric Wong <e@80x24.org>
Date: Thu, 12 Sep 2019 23:16:52 +0000 (+0000)
Subject: githttpbackend: use REMOTE_ADDR for deleted identifier
X-Git-Tag: v1.2.0~99
X-Git-Url: http://www.git.stargrave.org/?p=public-inbox.git;a=commitdiff_plain;h=500a3dad334601d928e20dd9d764fb117f65103d

githttpbackend: use REMOTE_ADDR for deleted identifier

REMOTE_HOST is not set by us (it is the reverse DNS name) of
REMOTE_ADDR, and there's few better ways to kill HTTP server
performance than to use standard name resolution APIs like
getnameinfo(3).
---

diff --git a/lib/PublicInbox/GitHTTPBackend.pm b/lib/PublicInbox/GitHTTPBackend.pm
index a8337035..c9a7cff8 100644
--- a/lib/PublicInbox/GitHTTPBackend.pm
+++ b/lib/PublicInbox/GitHTTPBackend.pm
@@ -219,7 +219,7 @@ sub input_prepare {
 	if (defined $fd && $fd >= 0) {
 		return { 0 => $fd };
 	}
-	my $id = "git-http.input.$env->{REMOTE_HOST}:$env->{REMOTE_PORT}";
+	my $id = "git-http.input.$env->{REMOTE_ADDR}:$env->{REMOTE_PORT}";
 	my $in = tmpfile($id);
 	unless (defined $in) {
 		err($env, "could not open temporary file: $!");