From: Eric Wong <e@80x24.org>
Date: Mon, 12 Sep 2022 16:04:48 +0000 (+0000)
Subject: git_async_cat: don't use Gcf2 for temporary git dirs
X-Git-Url: http://www.git.stargrave.org/?p=public-inbox.git;a=commitdiff_plain;h=598dcdbead54e1d4746dea762c2c3cf292e796fc

git_async_cat: don't use Gcf2 for temporary git dirs

We don't want to be holding references to temporary directories
longer than necessary, an Gcf is intended to be long-lived.
---

diff --git a/lib/PublicInbox/GitAsyncCat.pm b/lib/PublicInbox/GitAsyncCat.pm
index c12c4ec2..b32c2fd3 100644
--- a/lib/PublicInbox/GitAsyncCat.pm
+++ b/lib/PublicInbox/GitAsyncCat.pm
@@ -51,7 +51,8 @@ sub ibx_async_cat ($$$$) {
 	# {topdir} means ExtSearch (likely [extindex "all"]) with potentially
 	# 100K alternates.  git(1) has a proposed patch for 100K alternates:
 	# <https://lore.kernel.org/git/20210624005806.12079-1-e@80x24.org/>
-	if (!defined($ibx->{topdir}) && ($GCF2C //= eval {
+	if (!defined($ibx->{topdir}) && !defined($git->{-tmp}) &&
+		($GCF2C //= eval {
 		require PublicInbox::Gcf2Client;
 		PublicInbox::Gcf2Client::new();
 	} // 0)) { # 0: do not retry if libgit2 or Inline::C are missing