From: Eric Wong (Contractor, The Linux Foundation) <e@80x24.org>
Date: Sat, 7 Apr 2018 03:41:48 +0000 (+0000)
Subject: over: avoid excessive SELECT
X-Git-Tag: v1.1.0-pre1~43
X-Git-Url: http://www.git.stargrave.org/?p=public-inbox.git;a=commitdiff_plain;h=59b5b84b8843d54024b5bb182f02b9b487a1ed29

over: avoid excessive SELECT

No need to read what we don't need into the Perl process.
Fix some broken capitalization while we're at it.
---

diff --git a/lib/PublicInbox/Over.pm b/lib/PublicInbox/Over.pm
index da0f11e5..07e54b64 100644
--- a/lib/PublicInbox/Over.pm
+++ b/lib/PublicInbox/Over.pm
@@ -59,7 +59,7 @@ sub do_get {
 sub query_xover {
 	my ($self, $beg, $end) = @_;
 	do_get($self, <<'', {}, $beg, $end);
-SELECT * FROM over WHERE num >= ? AND num <= ?
+SELECT num,ts,ds,ddd FROM over WHERE num >= ? AND num <= ?
 ORDER BY num ASC
 
 }
@@ -131,7 +131,7 @@ sub recent {
 		}
 	}
 	my $msgs = do_get($self, <<"", $opts, @v);
-SELECT * FROM over WHERE $s
+SELECT ts,ds,ddd FROM over WHERE $s
 
 	return $msgs unless wantarray;
 
@@ -145,7 +145,7 @@ sub get_art {
 	my ($self, $num) = @_;
 	my $dbh = $self->connect;
 	my $smsg = $dbh->selectrow_hashref(<<'', undef, $num);
-SELECT * from OVER where num = ? LIMIT 1
+SELECT num,ds,ts,ddd FROM over WHERE num = ? LIMIT 1
 
 	return load_from_row($smsg) if $smsg;
 	undef;