From: Eric Wong <e@80x24.org>
Date: Sat, 21 Dec 2019 08:00:06 +0000 (+0000)
Subject: nntp: hdr_msg_id: use named sub for long_response
X-Git-Tag: v1.3.0~195
X-Git-Url: http://www.git.stargrave.org/?p=public-inbox.git;a=commitdiff_plain;h=61550976b8ff52ba3e621caa5b9c450bf34801ff

nntp: hdr_msg_id: use named sub for long_response

Introduce hdr_msgid_range_i, which does the same thing as the
anonymous sub it replaces.
---

diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index 1f31b4a5..fca632e2 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -646,6 +646,14 @@ sub long_response ($$;@) {
 	undef;
 }
 
+sub hdr_msgid_range_i {
+	my ($self, $beg, $end) = @_;
+	my $r = $self->{ng}->mm->msg_range($beg, $end);
+	@$r or return;
+	more($self, join("\r\n", map { "$_->[0] <$_->[1]>" } @$r));
+	1;
+}
+
 sub hdr_message_id ($$$) { # optimize XHDR Message-ID [range] for slrnpull.
 	my ($self, $xhdr, $range) = @_;
 
@@ -657,17 +665,8 @@ sub hdr_message_id ($$$) { # optimize XHDR Message-ID [range] for slrnpull.
 		$range = $self->{article} unless defined $range;
 		my $r = get_range($self, $range);
 		return $r unless ref $r;
-		my $mm = $self->{ng}->mm;
-		my ($beg, $end) = @$r;
 		more($self, $xhdr ? r221 : r225);
-		long_response($self, sub {
-			my $r = $mm->msg_range($beg, $end);
-			@$r or return;
-			more($self, join("\r\n", map {
-				"$_->[0] <$_->[1]>"
-			} @$r));
-			1;
-		});
+		long_response($self, \&hdr_msgid_range_i, @$r);
 	}
 }