From: Eric Wong <e@80x24.org>
Date: Tue, 24 Jan 2023 09:49:30 +0000 (+0000)
Subject: qspawn: drop lineno from command failure warning
X-Git-Url: http://www.git.stargrave.org/?p=public-inbox.git;a=commitdiff_plain;h=686fb938a2a27beca406af6e8ab819aad608b06e

qspawn: drop lineno from command failure warning

git, cgit, or any other command failing isn't an error
we can do anything about in qspawn, so don't have Perl
emit line number info and needlessly pollute logs.
---

diff --git a/lib/PublicInbox/Qspawn.pm b/lib/PublicInbox/Qspawn.pm
index cc81a4cd..5e4fd5cb 100644
--- a/lib/PublicInbox/Qspawn.pm
+++ b/lib/PublicInbox/Qspawn.pm
@@ -85,7 +85,7 @@ sub finalize ($) {
 		if (my $dst = $self->{qsp_err}) {
 			$$dst .= $$dst ? " $err" : "; $err";
 		}
-		warn "@{$self->{cmd}}: $err" if !$self->{-quiet};
+		warn "@{$self->{cmd}}: $err\n" if !$self->{-quiet};
 	}
 
 	my ($env, $qx_cb, $qx_arg, $qx_buf) =
diff --git a/t/solver_git.t b/t/solver_git.t
index 06d75816..122cf888 100644
--- a/t/solver_git.t
+++ b/t/solver_git.t
@@ -336,7 +336,7 @@ EOF
 			open $fh, '>', "$tmpdir/stderr.log" or xbail $!;
 			ok($s =~ s/^fatal: your current branch.*?\n//sm,
 				'got current branch warning');
-			ok($s =~ s/^.*? exit status=[1-9]+ .*?\n//sm,
+			ok($s =~ s/^.*? exit status=[1-9]+\n\z//sm,
 				'got exit status warning');
 			is($s, '', 'no unexpected warnings on empty coderepo');
 		}