From: Eric Wong (Contractor, The Linux Foundation) <e@80x24.org>
Date: Fri, 30 Mar 2018 20:31:48 +0000 (+0000)
Subject: convert: avoid redundant "done\n" statement for fast-import
X-Git-Tag: v1.1.0-pre1~87
X-Git-Url: http://www.git.stargrave.org/?p=public-inbox.git;a=commitdiff_plain;h=782b745180997e17fed3c7c2369a623ed2e05cfe

convert: avoid redundant "done\n" statement for fast-import

This bug was hidden due to timing problems with eatmydata or
running with tmpfs for TMPDIR.
---

diff --git a/script/public-inbox-convert b/script/public-inbox-convert
index 2b0a385e..e6fb4f5f 100755
--- a/script/public-inbox-convert
+++ b/script/public-inbox-convert
@@ -91,9 +91,8 @@ while (<$rd>) {
 			$from = $1;
 			# no next
 		}
-	} elsif ($_ eq "done\n") {
-		last;
 	}
+	last if $_ eq "done\n";
 	$w->print($_) or $im->wfail;
 }
 $w = $r = undef;