From: Eric Wong <e@80x24.org>
Date: Tue, 19 Jul 2022 02:36:04 +0000 (+0000)
Subject: searchidx: skip "delta $N" sections for base-85
X-Git-Tag: v1.9.0~103
X-Git-Url: http://www.git.stargrave.org/?p=public-inbox.git;a=commitdiff_plain;h=840785917bc74c8e7df226463144185294047d75;hp=d323a16ced5e3a77136a1ebca4a2f7d5678121c4

searchidx: skip "delta $N" sections for base-85

I don't deal with binary patches ever, so I failed to notice
binary deltas are supported in addition to the more common
literals.

A quick check of apply.c in git.git confirms "delta" and
"literal" are the only binary patch classes we can expect.
---

diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm
index cbfe7816..bdb84fc7 100644
--- a/lib/PublicInbox/SearchIdx.pm
+++ b/lib/PublicInbox/SearchIdx.pm
@@ -263,10 +263,10 @@ sub index_diff ($$$) {
 	while (defined($_ = shift @l)) {
 		if ($in_diff && /^GIT binary patch/) {
 			push @$xnq, $_;
-			while (@l && $l[0] =~ /^literal /) {
+			while (@l && $l[0] =~ /^(?:literal|delta) /) {
 				# TODO allow searching by size range?
 				# allows searching by exact size via:
-				# "literal $SIZE"
+				# "literal $SIZE" or "delta $SIZE"
 				push @$xnq, shift(@l);
 
 				# skip base85 and empty lines