From: Eric Wong <e@80x24.org>
Date: Tue, 1 May 2018 01:51:41 +0000 (+0000)
Subject: searchidx: preserve umask when starting/committing transactions
X-Git-Tag: v1.1.0-pre1~3
X-Git-Url: http://www.git.stargrave.org/?p=public-inbox.git;a=commitdiff_plain;h=9d5059d2904e7858460dc71a1f55c27d79583385

searchidx: preserve umask when starting/committing transactions

Xapian will replace files upon committing, so non-parallel
V2Writable users need to have umask preserved this way.
---

diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm
index aeb363e0..74f9267e 100644
--- a/lib/PublicInbox/SearchIdx.pm
+++ b/lib/PublicInbox/SearchIdx.pm
@@ -752,18 +752,23 @@ sub remote_remove {
 sub begin_txn_lazy {
 	my ($self) = @_;
 	return if $self->{txn};
-	my $xdb = $self->{xdb} || $self->_xdb_acquire;
-	$self->{over}->begin_lazy if $self->{over};
-	$xdb->begin_transaction;
-	$self->{txn} = 1;
-	$xdb;
+
+	$self->{-inbox}->with_umask(sub {
+		my $xdb = $self->{xdb} || $self->_xdb_acquire;
+		$self->{over}->begin_lazy if $self->{over};
+		$xdb->begin_transaction;
+		$self->{txn} = 1;
+		$xdb;
+	});
 }
 
 sub commit_txn_lazy {
 	my ($self) = @_;
 	delete $self->{txn} or return;
-	$self->{xdb}->commit_transaction;
-	$self->{over}->commit_lazy if $self->{over};
+	$self->{-inbox}->with_umask(sub {
+		$self->{xdb}->commit_transaction;
+		$self->{over}->commit_lazy if $self->{over};
+	});
 }
 
 sub worker_done {