From: Eric Wong <e@80x24.org>
Date: Wed, 8 May 2019 02:53:03 +0000 (+0000)
Subject: nntp: avoid uninitialized variable from blank requests
X-Git-Tag: v1.2.0~297
X-Git-Url: http://www.git.stargrave.org/?p=public-inbox.git;a=commitdiff_plain;h=a316ca7db9fd3ea7dded317ac6d4d0a6bf174fb3

nntp: avoid uninitialized variable from blank requests

We'll ignore blank lines from clients, since that's what innd
seems to do.
---

diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index 13591e5d..e8331577 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -122,7 +122,7 @@ sub args_ok ($$) {
 sub process_line ($$) {
 	my ($self, $l) = @_;
 	my ($req, @args) = split(/\s+/, $l);
-	return unless defined($req);
+	return 1 unless defined($req); # skip blank line
 	$req = lc($req);
 	$req = eval {
 		no strict 'refs';