From: Eric Wong <e@yhbt.net>
Date: Sat, 4 Apr 2020 23:51:41 +0000 (+0000)
Subject: xt/msgtime_cmp: fix false positives from msgtime change
X-Git-Tag: v1.4.0~23
X-Git-Url: http://www.git.stargrave.org/?p=public-inbox.git;a=commitdiff_plain;h=b6fc8916a05176ef006b07bba977b59cdf6a0bce

xt/msgtime_cmp: fix false positives from msgtime change

commit d857e7dc0d816b635a7ead09c3273f8c2d2434be
("msgtime: assume +0000 if TZ missing when using Date::Parse")
introduced a behavior change which was causes false positives
when compared to the old code.

Update the "old" implementation to match this overdue behavior
change.
---

diff --git a/xt/msgtime_cmp.t b/xt/msgtime_cmp.t
index b77e57a6..4ebf5b2c 100644
--- a/xt/msgtime_cmp.t
+++ b/xt/msgtime_cmp.t
@@ -82,6 +82,13 @@ sub str2date_zone ($) {
 
 	# off is the time zone offset in seconds from GMT
 	my ($ss,$mm,$hh,$day,$month,$year,$off) = Date::Parse::strptime($date);
+
+	# new behavior which wasn't in the original old version:
+	if ('commit d857e7dc0d816b635a7ead09c3273f8c2d2434be') {
+		# "msgtime: assume +0000 if TZ missing when using Date::Parse"
+		$off //= '+0000';
+	}
+
 	return undef unless(defined $off);
 
 	# Compute the time zone from offset