From: Eric Wong <e@80x24.org>
Date: Thu, 29 Jun 2017 00:10:38 +0000 (+0000)
Subject: hval: only perform one substitution when obfuscating
X-Git-Tag: v1.0.0~31
X-Git-Url: http://www.git.stargrave.org/?p=public-inbox.git;a=commitdiff_plain;h=cfb0a03a8966c71820e4536eaf31265ea79397e6

hval: only perform one substitution when obfuscating

Only one substitution character is necessary when obfuscating
email addresses.
---

diff --git a/lib/PublicInbox/Hval.pm b/lib/PublicInbox/Hval.pm
index 80050886..8d36fc2b 100644
--- a/lib/PublicInbox/Hval.pm
+++ b/lib/PublicInbox/Hval.pm
@@ -100,7 +100,7 @@ sub obfuscate_addrs ($$) {
 		if ($addrs->{$addr} || ((defined $re && $domain =~ $re))) {
 			$addr;
 		} else {
-			$addr =~ s!([^\.]+)\.!$1&#8226;!g;
+			$addr =~ s!([^\.]+)\.!$1&#8226;!;
 			$addr
 		}
 		/sge;
diff --git a/t/hval.t b/t/hval.t
index dcbd8382..a3712666 100644
--- a/t/hval.t
+++ b/t/hval.t
@@ -17,6 +17,7 @@ hello@example.comm
 hello@example.com
 meta@public-inbox.org
 test@public-inbox.org
+test@a.b.c.org
 EOF
 
 PublicInbox::Hval::obfuscate_addrs($ibx, $html);
@@ -26,6 +27,7 @@ hello@example&#8226;comm
 hello@example.com
 meta@public-inbox.org
 test@public-inbox&#8226;org
+test@a&#8226;b.c.org
 EOF
 
 is($html, $exp, 'only obfuscated relevant addresses');