From: Eric Wong <e@80x24.org>
Date: Fri, 23 Dec 2022 06:05:39 +0000 (+0000)
Subject: lei_mirror: allow `git show-ref' failures
X-Git-Url: http://www.git.stargrave.org/?p=public-inbox.git;a=commitdiff_plain;h=f1817699f3f3feb964653eaf3586477abbf7947d

lei_mirror: allow `git show-ref' failures

`git show-ref' may fail on initialized-but-empty repositories.
So just unconditionally fetch those repos if we're in that
situation.
---

diff --git a/lib/PublicInbox/LeiMirror.pm b/lib/PublicInbox/LeiMirror.pm
index 92156cf1..9843d1a6 100644
--- a/lib/PublicInbox/LeiMirror.pm
+++ b/lib/PublicInbox/LeiMirror.pm
@@ -461,7 +461,11 @@ EOM
 }
 
 sub fp_done {
-	my ($self, $cb, @arg) = @_;
+	my ($self, $cmd, $cb, @arg) = @_;
+	if ($?) {
+		$self->{lei}->err("@$cmd failed (\$?=$?) (non-fatal)");
+		$? = 0; # don't let it influence normal exit
+	}
 	return if !keep_going($self);
 	my $fh = delete $self->{-show_ref} // die 'BUG: no show-ref output';
 	seek($fh, SEEK_SET, 0) or die "seek(show_ref): $!";
@@ -487,8 +491,11 @@ sub cmp_fp_do {
 	my $opt = { 2 => $self->{lei}->{2} };
 	open($opt->{1}, '+>', undef) or die "open(tmp): $!";
 	$self->{-show_ref} = $opt->{1};
-	my $done = PublicInbox::OnDestroy->new($$, \&fp_done, $self, $cb, @arg);
-	start_cmd($self, $cmd, $opt, $done);
+	do_reap($self);
+	$self->{lei}->qerr("# @$cmd");
+	return if $self->{dry_run};
+	$LIVE->{spawn($cmd, undef, $opt)} = [ \&fp_done, $self, $cmd,
+						$cb, @arg ];
 }
 
 sub resume_fetch {