From 18798ea686b3c5cc46831e6b3bd1dec0cefa3137 Mon Sep 17 00:00:00 2001
From: Eric Wong <e@80x24.org>
Date: Sun, 7 Feb 2021 08:52:00 +0000
Subject: [PATCH] imap: avoid unnecessary on-stack delete

None of the Content-Type attributes are long-lived
(and unlikely to be memory intensive).  While these
callsites won't trigger $DB::args segfaults via
confess or longmess, it'll make future code audits
easier.

cf. commit 0795b0906cc81f40
    ("ds: guard against stack-not-refcounted quirk of Perl 5")
---
 lib/PublicInbox/IMAP.pm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/PublicInbox/IMAP.pm b/lib/PublicInbox/IMAP.pm
index 226e98a2..af8ce72b 100644
--- a/lib/PublicInbox/IMAP.pm
+++ b/lib/PublicInbox/IMAP.pm
@@ -499,7 +499,7 @@ sub body_disposition ($) {
 	my $cd = $eml->header_raw('Content-Disposition') or return 'NIL';
 	$cd = parse_content_disposition($cd);
 	my $buf = '('._esc($cd->{type});
-	$buf .= ' ' . _esc_hash(delete $cd->{attributes});
+	$buf .= ' ' . _esc_hash($cd->{attributes});
 	$buf .= ')';
 }
 
@@ -511,7 +511,7 @@ sub body_leaf ($$;$) {
 	my $ct = $eml->ct;
 	$buf .= '('._esc($ct->{type}).' ';
 	$buf .= _esc($ct->{subtype});
-	$buf .= ' ' . _esc_hash(delete $ct->{attributes});
+	$buf .= ' ' . _esc_hash($ct->{attributes});
 	$buf .= ' ' . _esc($eml->header_raw('Content-ID'));
 	$buf .= ' ' . _esc($eml->header_raw('Content-Description'));
 	my $cte = $eml->header_raw('Content-Transfer-Encoding') // '7bit';
@@ -540,7 +540,7 @@ sub body_parent ($$$) {
 		$buf .= @$hold ? join('', @$hold) : 'NIL';
 		$buf .= ' '._esc($ct->{subtype});
 		if ($structure) {
-			$buf .= ' '._esc_hash(delete $ct->{attributes});
+			$buf .= ' '._esc_hash($ct->{attributes});
 			$buf .= ' '.body_disposition($eml);
 			$buf .= ' '._esc($eml->header_raw('Content-Language'));
 			$buf .= ' '._esc($eml->header_raw('Content-Location'));
-- 
2.44.0