From 1f15ff775a967794ff3e409722b72e5684f2c0a2 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Thu, 15 Jun 2017 23:07:58 +0000 Subject: [PATCH] searchidx: remove messages correctly from Xapian index This fixes a bug introduced in commit 7eeadcb62729b0efbcb53cd9b7b181897c92cf9a ("search: remove unnecessary abstractions and functionality") --- lib/PublicInbox/SearchIdx.pm | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm index 9ba9437d..69b7a6f6 100644 --- a/lib/PublicInbox/SearchIdx.pm +++ b/lib/PublicInbox/SearchIdx.pm @@ -366,8 +366,12 @@ sub remove_message { $mid = mid_clean($mid); eval { - $doc_id = $self->find_unique_doc_id('mid', $mid); - $db->delete_document($doc_id) if defined $doc_id; + $doc_id = $self->find_unique_doc_id('Q' . $mid); + if (defined $doc_id) { + $db->delete_document($doc_id); + } else { + warn "cannot remove non-existent <$mid>\n"; + } }; if ($@) { -- 2.44.0