From 32d4bd7489d5193f82dee52a6b08eda2c775caf5 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Fri, 23 Dec 2022 11:05:13 +0000 Subject: [PATCH] httpd/async: remove useless undef Assigning `undef' to a scalar doesn't free it's memory, we need to call `undef($var)' in the caller. It's also been pointless since we simplified ->async_pass in commit b7fbffd1f8c12556 (httpd/async: get rid of ephemeral main_cb, 2019-12-25) --- lib/PublicInbox/HTTPD/Async.pm | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/PublicInbox/HTTPD/Async.pm b/lib/PublicInbox/HTTPD/Async.pm index 9e592f47..75b3bd50 100644 --- a/lib/PublicInbox/HTTPD/Async.pm +++ b/lib/PublicInbox/HTTPD/Async.pm @@ -84,10 +84,6 @@ sub async_pass { # *_wcb methods respond to ->write (and ->close), not ->print $fh->write($$bref); - # we're done with this, free this memory up ASAP since the - # calls after this may use much memory: - $$bref = undef; - $self->{http} = $http; $self->{fh} = $fh; } -- 2.44.0