From 364de65f8a6b5729027cb70228312a141430122f Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Tue, 14 Feb 2017 22:45:15 +0000 Subject: [PATCH] www: do not unescape PATH_INFO twice PSGI specs already require PATH_INFO to be unescaped; so our tests were wrong, too. --- lib/PublicInbox/WWW.pm | 2 +- t/cgi.t | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/WWW.pm b/lib/PublicInbox/WWW.pm index 430e6b19..62e4ca43 100644 --- a/lib/PublicInbox/WWW.pm +++ b/lib/PublicInbox/WWW.pm @@ -165,7 +165,7 @@ sub invalid_inbox_mid { my $ret = invalid_inbox($ctx, $inbox); return $ret if $ret; - $ctx->{mid} = $mid = uri_unescape($mid); + $ctx->{mid} = $mid; if ($mid =~ /\A[a-f0-9]{40}\z/) { # this is horiffically wasteful for legacy URLs: if ($mid = mid2blob($ctx)) { diff --git a/t/cgi.t b/t/cgi.t index 092ad8c7..77409660 100644 --- a/t/cgi.t +++ b/t/cgi.t @@ -148,7 +148,7 @@ EOF $im->add($reply); $im->done; - my $res = cgi_run("/test/slashy%2fasdf\@example.com/raw"); + my $res = cgi_run("/test/slashy/asdf\@example.com/raw"); like($res->{body}, qr/Message-Id: <\Q$slashy_mid\E>/, "slashy mid raw hit"); -- 2.44.0