From 36db110eb3befcb28627d0f3d2d618aa3f1bf76c Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Thu, 23 Jan 2020 23:05:58 +0000 Subject: [PATCH] wwwstream: shorten cloneurl uniquification Another place where List::Scalar::uniq doesn't make sense, but there's a small op reduction to be had anyways. --- lib/PublicInbox/WwwStream.pm | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/PublicInbox/WwwStream.pm b/lib/PublicInbox/WwwStream.pm index 8f5a6526..a724d069 100644 --- a/lib/PublicInbox/WwwStream.pm +++ b/lib/PublicInbox/WwwStream.pm @@ -89,12 +89,12 @@ sub _html_end { my $ibx = $ctx->{-inbox}; my $desc = ascii_html($ibx->description); - my (%seen, @urls); + my @urls; my $http = $self->{base_url}; my $max = $ibx->max_git_epoch; my $dir = (split(m!/!, $http))[-1]; + my %seen = ($http => 1); if (defined($max)) { # v2 - $seen{$http} = 1; for my $i (0..$max) { # old parts my be deleted: -d "$ibx->{inboxdir}/git/$i.git" or next; @@ -103,15 +103,13 @@ sub _html_end { push @urls, "$url $dir/git/$i.git"; } } else { # v1 - $seen{$http} = 1; push @urls, $http; } # FIXME: epoch splits can be different in other repositories, # use the "cloneurl" file as-is for now: foreach my $u (@{$ibx->cloneurl}) { - next if $seen{$u}; - $seen{$u} = 1; + next if $seen{$u}++; push @urls, $u =~ /\Ahttps?:/ ? qq($u) : $u; } -- 2.44.0