From 48d4fdb2acbf8cf05dcb357df53b0d658f88fe39 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sun, 24 Nov 2019 03:12:37 +0000 Subject: [PATCH] check for File::Temp 0.19 for ->newdir method This is distributed with Perl 5.10.1 and onwards, so it should not be an installation burden for any users. I'm planning to move away from tempdir() entirely and use File::Temp->newdir to remove dependencies on END{} blocks. --- Makefile.PL | 2 +- lib/PublicInbox/SolverGit.pm | 2 +- lib/PublicInbox/WatchMaildir.pm | 2 +- script/public-inbox-edit | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile.PL b/Makefile.PL index 1c70c6f3..f650fdea 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -54,7 +54,7 @@ WriteMakefile( # All Perl installs I know about have these, but RH-based # distros make them separate even though 'perl' pulls them in 'File::Path' => 0, - 'File::Temp' => 0, + 'File::Temp' => '0.19', 'Getopt::Long' => 0, 'Exporter' => 0, # ExtUtils::MakeMaker # this file won't run w/o it... diff --git a/lib/PublicInbox/SolverGit.pm b/lib/PublicInbox/SolverGit.pm index 95334d7a..eea59b6d 100644 --- a/lib/PublicInbox/SolverGit.pm +++ b/lib/PublicInbox/SolverGit.pm @@ -10,7 +10,7 @@ package PublicInbox::SolverGit; use strict; use warnings; -use File::Temp qw(); +use File::Temp 0.19 (); use Fcntl qw(SEEK_SET); use PublicInbox::Git qw(git_unquote git_quote); use PublicInbox::MsgIter qw(msg_iter msg_part_text); diff --git a/lib/PublicInbox/WatchMaildir.pm b/lib/PublicInbox/WatchMaildir.pm index e9231780..003baec9 100644 --- a/lib/PublicInbox/WatchMaildir.pm +++ b/lib/PublicInbox/WatchMaildir.pm @@ -9,7 +9,7 @@ use warnings; use PublicInbox::MIME; use PublicInbox::Spawn qw(spawn); use PublicInbox::InboxWritable; -use File::Temp qw//; +use File::Temp 0.19 (); use PublicInbox::Filter::Base; use PublicInbox::Spamcheck; *REJECT = *PublicInbox::Filter::Base::REJECT; diff --git a/script/public-inbox-edit b/script/public-inbox-edit index 1900b267..2a9f0531 100755 --- a/script/public-inbox-edit +++ b/script/public-inbox-edit @@ -8,7 +8,7 @@ use strict; use warnings; use Getopt::Long qw(:config gnu_getopt no_ignore_case auto_abbrev); use PublicInbox::AdminEdit; -use File::Temp (); +use File::Temp 0.19 (); use PublicInbox::ContentId qw(content_id); use PublicInbox::MID qw(mid_clean mids); PublicInbox::Admin::check_require('-index'); -- 2.44.0