From 4de32cbee1bab278a15cd83e7c620de0d7777be5 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Tue, 3 Mar 2020 09:50:57 +0000 Subject: [PATCH] spawn: correctly handle error code Both the C and pure Perl implementions of `pi_fork_exec' returns `-1' on error, not `undef'. --- lib/PublicInbox/Spawn.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/Spawn.pm b/lib/PublicInbox/Spawn.pm index 2d9f734c..ad6be187 100644 --- a/lib/PublicInbox/Spawn.pm +++ b/lib/PublicInbox/Spawn.pm @@ -210,7 +210,7 @@ sub spawn ($;$$) { } my $cd = $opts->{'-C'} // ''; # undef => NULL mapping doesn't work? my $pid = pi_fork_exec($redir, $f, $cmd, \@env, $rlim, $cd); - die "fork_exec failed: $!\n" unless defined $pid; + die "fork_exec failed: $!\n" unless $pid > 0; $pid; } -- 2.44.0