From 5fdedf809e7f236c7e50177bff8426a9befbcceb Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Mon, 10 Aug 2020 02:11:59 +0000 Subject: [PATCH] admin: use a generic variable name We parse other options, too, not just --max-size --- Documentation/public-inbox-index.pod | 2 +- lib/PublicInbox/Admin.pm | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/public-inbox-index.pod b/Documentation/public-inbox-index.pod index 3ae3b008..10cf2d19 100644 --- a/Documentation/public-inbox-index.pod +++ b/Documentation/public-inbox-index.pod @@ -179,7 +179,7 @@ C<4m> have little benefit. For L inboxes, this value is multiplied by the number of Xapian shards. Thus a typical v2 inbox with 3 shards will flush every 3 megabytes by default -when unless parallelism is disabled via C<--sequential-shard> +unless parallelism is disabled via C<--sequential-shard> or C<--jobs=0>. This influences memory usage of Xapian, but it is not exact. diff --git a/lib/PublicInbox/Admin.pm b/lib/PublicInbox/Admin.pm index af2b3da9..8a9a81c9 100644 --- a/lib/PublicInbox/Admin.pm +++ b/lib/PublicInbox/Admin.pm @@ -256,12 +256,12 @@ sub progress_prepare ($) { # same unit factors as git: sub parse_unsigned ($) { - my ($max_size) = @_; + my ($val) = @_; - $$max_size =~ /\A([0-9]+)([kmg])?\z/i or return; + $$val =~ /\A([0-9]+)([kmg])?\z/i or return; my ($n, $unit_factor) = ($1, $2 // ''); my %u = ( k => 1024, m => 1024**2, g => 1024**3 ); - $$max_size = $n * ($u{lc($unit_factor)} // 1); + $$val = $n * ($u{lc($unit_factor)} // 1); 1; } -- 2.44.0