From 6896585267c269cb344b01af102f6f73602548ad Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sun, 25 Jul 2021 00:11:02 +0000 Subject: [PATCH] extindex: improve comment around git->async_wait_all I found myself tempted to remove this, but it appears impossible due to odd messages which have multiple Message-IDs. --- lib/PublicInbox/ExtSearchIdx.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm index 2311161e..1c2a9758 100644 --- a/lib/PublicInbox/ExtSearchIdx.pm +++ b/lib/PublicInbox/ExtSearchIdx.pm @@ -937,7 +937,9 @@ EOS }; $self->git->cat_async($smsg->{blob}, \&dd_smsg, $dd); } - # need to wait on every single one + # need to wait on every single one @smsg contents can get + # invalidated inside dd_smsg for messages with multiple + # Message-IDs. $self->git->async_wait_all; if (checkpoint_due($sync)) { -- 2.44.0