From 7f4a11a6499aade26b418b7ae13cd12859f75bdd Mon Sep 17 00:00:00 2001
From: Eric Wong <e@yhbt.net>
Date: Thu, 27 Aug 2020 12:17:01 +0000
Subject: [PATCH] overidx: inline create_ghost sub

There's no need for this to be a separate sub since there's
only a single caller.  This saves a few kilobytes at least
in short-lived processes.
---
 lib/PublicInbox/OverIdx.pm | 23 ++++++++++-------------
 t/over.t                   |  4 ++--
 2 files changed, 12 insertions(+), 15 deletions(-)

diff --git a/lib/PublicInbox/OverIdx.pm b/lib/PublicInbox/OverIdx.pm
index 67f8cf65..6f0477f0 100644
--- a/lib/PublicInbox/OverIdx.pm
+++ b/lib/PublicInbox/OverIdx.pm
@@ -184,23 +184,20 @@ sub resolve_mid_to_tid {
 	if (my $del = delete $self->{-ghosts_to_delete}) {
 		delete_by_num($self, $_) for @$del;
 	}
-	$tid // create_ghost($self, $mid);
-}
-
-sub create_ghost {
-	my ($self, $mid) = @_;
-	my $id = mid2id($self, $mid);
-	my $num = next_ghost_num($self);
-	$num < 0 or die "ghost num is non-negative: $num\n";
-	my $tid = next_tid($self);
-	my $dbh = $self->{dbh};
-	$dbh->prepare_cached(<<'')->execute($num, $tid);
+	$tid // do { # create a new ghost
+		my $id = mid2id($self, $mid);
+		my $num = next_ghost_num($self);
+		$num < 0 or die "ghost num is non-negative: $num\n";
+		$tid = next_tid($self);
+		my $dbh = $self->{dbh};
+		$dbh->prepare_cached(<<'')->execute($num, $tid);
 INSERT INTO over (num, tid) VALUES (?,?)
 
-	$dbh->prepare_cached(<<'')->execute($id, $num);
+		$dbh->prepare_cached(<<'')->execute($id, $num);
 INSERT INTO id2num (id, num) VALUES (?,?)
 
-	$tid;
+		$tid;
+	};
 }
 
 sub merge_threads {
diff --git a/t/over.t b/t/over.t
index 41c13872..4c8f8098 100644
--- a/t/over.t
+++ b/t/over.t
@@ -33,9 +33,9 @@ $over->dbh;
 is($over->sid('hello-world'), $x, 'idempotent across reopen');
 $over->each_by_mid('never', sub { fail('should not be called') });
 
-$x = $over->create_ghost('never');
+$x = $over->resolve_mid_to_tid('never');
 is(int($x), $x, 'integer tid for ghost');
-$y = $over->create_ghost('NEVAR');
+$y = $over->resolve_mid_to_tid('NEVAR');
 is($y, $x + 1, 'integer tid for ghost increases');
 
 my $ddd = compress('');
-- 
2.44.0