From 9537b9c7201a7c656c3efcb9918df930a7447981 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Mon, 28 Nov 2022 05:31:58 +0000 Subject: [PATCH] clone: require `--objstore=' for default location Allowing just `--objstore' without `=' was confusing, since it could eat one of the required parameters (URL or DESTINATION). --- Documentation/public-inbox-clone.pod | 8 ++++---- script/public-inbox-clone | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Documentation/public-inbox-clone.pod b/Documentation/public-inbox-clone.pod index cee9f76e..257967d9 100644 --- a/Documentation/public-inbox-clone.pod +++ b/Documentation/public-inbox-clone.pod @@ -84,15 +84,15 @@ Force a remote public-inbox version (must be C<1> or C<2>). This is auto-detected by default, and this option exists mainly for testing. -=item --objstore[=DIR] +=item --objstore=DIR Enables space savings when the remote C includes C entries as generated by grokmirror 2.x. If C is not an absolute path, it is relative to the -C directory. If only C<--objstore> is specified -without C, then C (C<$DESTINATION/objstore>) -is the implied value of C. +C directory. If only C<--objstore=> is specified +where C is an empty string (C<"">), then C +(C<$DESTINATION/objstore>) is the implied value of C. =item -n diff --git a/script/public-inbox-clone b/script/public-inbox-clone index 26f42e74..e38d7b0d 100755 --- a/script/public-inbox-clone +++ b/script/public-inbox-clone @@ -13,7 +13,7 @@ usage: public-inbox-clone INBOX_URL [DESTINATION] options: --epoch=RANGE range of v2 epochs to clone (e.g `2..5', `~0', `~1..') - --objstore [DIR] share storage for coderepos + --objstore=DIR share storage for coderepos --torsocks VAL whether or not to wrap git and curl commands with torsocks (default: `auto') Must be one of: `auto', `no' or `yes' @@ -23,7 +23,7 @@ options: -C DIR chdir to specified directory EOF GetOptions($opt, qw(help|h quiet|q verbose|v+ C=s@ c=s@ include|I=s@ exclude=s@ - inbox-config=s inbox-version=i objstore:s + inbox-config=s inbox-version=i objstore=s dry-run|n jobs|j=i no-torsocks torsocks=s epoch=s)) or die $help; if ($opt->{help}) { print $help; exit }; require PublicInbox::Admin; # loads Config -- 2.44.0