From a5c21c6e800be4755848621ba223594b0bde4d95 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sun, 21 Jun 2020 19:23:25 +0000 Subject: [PATCH] imap: refill_xap: remove needless loop There's no need to loop when the first iteration guarantees a `return'. --- lib/PublicInbox/IMAP.pm | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/lib/PublicInbox/IMAP.pm b/lib/PublicInbox/IMAP.pm index d8b1fce1..dec10d61 100644 --- a/lib/PublicInbox/IMAP.pm +++ b/lib/PublicInbox/IMAP.pm @@ -1172,16 +1172,13 @@ sub refill_xap ($$$$) { my $srch = $self->{ibx}->search; my $opt = { mset => 2, limit => 1000 }; my $nshard = $srch->{nshard} // 1; - while (1) { - my $mset = $srch->query("$q uid:$beg..$end", $opt); - @$uids = map { mdocid($nshard, $_) } $mset->items; - if (@$uids) { - $range_info->[0] = $uids->[-1] + 1; # update $beg - return; - } else { # all done - return 0; - } + my $mset = $srch->query("$q uid:$beg..$end", $opt); + @$uids = map { mdocid($nshard, $_) } $mset->items; + if (@$uids) { + $range_info->[0] = $uids->[-1] + 1; # update $beg + return; # possibly more } + 0; # all done } sub search_xap_range { # long_response -- 2.44.0