From b782533a0413578de4cfd478c67a8e3d9dda0949 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 26 Dec 2020 08:12:52 +0000 Subject: [PATCH] inbox: name variable for values loop iterator ->on_inbox_unlock callbacks could clobber $_, and this seems to fix a problem with -extindex --watch failing to index some inboxes after SIGHUP reload. (cherry picked from commit b5e960f50289434025f5904c8c1311e4c8a02b82) --- lib/PublicInbox/Inbox.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm index b0894a7d..e9efd29d 100644 --- a/lib/PublicInbox/Inbox.pm +++ b/lib/PublicInbox/Inbox.pm @@ -422,8 +422,8 @@ sub on_unlock { my ($self) = @_; check_inodes($self); my $subs = $self->{unlock_subs} or return; - for (values %$subs) { - eval { $_->on_inbox_unlock($self) }; + for my $obj (values %$subs) { + eval { $obj->on_inbox_unlock($self) }; warn "E: $@ ($self->{inboxdir})\n" if $@; } } -- 2.44.0