From b9a2b0a73585462288a0d82a2293e6ef2d601d2a Mon Sep 17 00:00:00 2001
From: Eric Wong <e@80x24.org>
Date: Sat, 23 Jul 2022 04:41:45 +0000
Subject: [PATCH] nntp: pass regexp to split() callers

Current implementations of Perl5 don't have optimizations for
single-character field separators.
---
 lib/PublicInbox/NNTP.pm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index b36722d7..3d304c52 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -1,4 +1,4 @@
-# Copyright (C) 2015-2021 all contributors <meta@public-inbox.org>
+# Copyright (C) all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 #
 # Each instance of this represents a NNTP client socket
@@ -71,7 +71,7 @@ sub new ($$$) {
 sub args_ok ($$) {
 	my ($cb, $argc) = @_;
 	my $tot = prototype $cb;
-	my ($nreq, undef) = split(';', $tot);
+	my ($nreq, undef) = split(/;/, $tot);
 	$nreq = ($nreq =~ tr/$//) - 1;
 	$tot = ($tot =~ tr/$//) - 1;
 	($argc <= $tot && $argc >= $nreq);
@@ -349,7 +349,7 @@ sub cmd_newnews ($$$$;$$) {
 	my $ts = eval { parse_time($date, $time, $gmt) };
 	return r501 if $@;
 	more($self, '230 list of new articles by message-id follows');
-	my ($keep, $skip) = split('!', $newsgroups, 2);
+	my ($keep, $skip) = split(/!/, $newsgroups, 2);
 	ngpat2re($keep);
 	ngpat2re($skip);
 	my @names = grep(!/$skip/, grep(/$keep/,
-- 
2.44.0