From de2598aaab55155334f06a74a44e9c615914a4d9 Mon Sep 17 00:00:00 2001
From: Eric Wong <e@80x24.org>
Date: Wed, 30 Apr 2014 00:16:55 +0000
Subject: [PATCH] favor "--git-dir=..." over "--git-dir ..."

This might improve grep-ability slightly and reduce allocations
while we're at it.
---
 lib/PublicInbox/GitCatFile.pm | 4 ++--
 public-inbox.cgi              | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/PublicInbox/GitCatFile.pm b/lib/PublicInbox/GitCatFile.pm
index bdad2b56..b3d9bfb7 100644
--- a/lib/PublicInbox/GitCatFile.pm
+++ b/lib/PublicInbox/GitCatFile.pm
@@ -17,8 +17,8 @@ sub _cat_file_begin {
 	my ($self) = @_;
 	return if $self->{pid};
 	my ($in, $out);
-	my $pid = open2($in, $out, 'git', '--git-dir', $self->{git_dir},
-			'cat-file', '--batch');
+	my $pid = open2($in, $out, 'git', "--git-dir=$self->{git_dir}",
+			qw(cat-file --batch));
 
 	$self->{pid} = $pid;
 	$self->{in} = $in;
diff --git a/public-inbox.cgi b/public-inbox.cgi
index 6f20e145..557d4923 100755
--- a/public-inbox.cgi
+++ b/public-inbox.cgi
@@ -149,7 +149,7 @@ sub mid2blob {
 	require IPC::Run;
 	my ($in, $blob, $err);
 	open my $null, '+<', '/dev/null' or die "open: $!\n";
-	IPC::Run::run(['git', '--git-dir', $ctx->{git_dir},
+	IPC::Run::run(['git', "--git-dir=$ctx->{git_dir}",
 			qw(cat-file blob), "HEAD:$1/$2"],
 			$null, \$blob, $null);
 	$? == 0 ? \$blob : undef;
-- 
2.44.0