From e700c37c0186915253d639462cfa403fd9fc964f Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Fri, 17 Apr 2020 09:33:31 +0000 Subject: [PATCH] qspawn: remove Perl 5.16.x leak workaround It seems no longer necessary to workaround this Perl 5.16.3 bug after the removal of anonymous subs from all of our internal code in https://public-inbox.org/meta/20191225075104.22184-1-e@80x24.org/ Tested with repeated clones (both aborted and completed) in a CentOS 7.x VM which was once able to reproduce leaks before the workaround appeared in 2fc42236f72ad16a ("qspawn: workaround Perl 5.16.3 leak, re-enable Deflater") Cc: Konstantin Ryabitsev --- lib/PublicInbox/Qspawn.pm | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/PublicInbox/Qspawn.pm b/lib/PublicInbox/Qspawn.pm index aebcb1f7..c09e8d2c 100644 --- a/lib/PublicInbox/Qspawn.pm +++ b/lib/PublicInbox/Qspawn.pm @@ -281,10 +281,6 @@ sub psgi_return_init_cb { ${$self->{hdr_buf}}, $filter); $wcb->($r); } - - # Workaround a leak under Perl 5.16.3 when combined with - # Plack::Middleware::Deflater: - $wcb = undef; } sub psgi_return_start { # may run later, much later... -- 2.44.0