From f1a3ece0df6825792f1ec0ca326998c8915fd80d Mon Sep 17 00:00:00 2001 From: "Eric Wong (Contractor, The Linux Foundation)" Date: Fri, 30 Mar 2018 18:15:25 +0000 Subject: [PATCH] t/v2writable: use simplify permissions reading We have Git::qx nowadays. --- t/v2writable.t | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/t/v2writable.t b/t/v2writable.t index 0eda432a..7abb14f6 100644 --- a/t/v2writable.t +++ b/t/v2writable.t @@ -43,13 +43,9 @@ if ('ensure git configs are correct') { qw(core.sharedRepository 0644)); is(system(@cmd), 0, "set sharedRepository in all.git"); $git0 = PublicInbox::Git->new("$mainrepo/git/0.git"); - my $fh = $git0->popen(qw(config core.sharedRepository)); - my $v = eval { local $/; <$fh> }; - chomp $v; + chomp(my $v = $git0->qx(qw(config core.sharedRepository))); is($v, '0644', 'child repo inherited core.sharedRepository'); - $fh = $git0->popen(qw(config --bool repack.writeBitmaps)); - $v = eval { local $/; <$fh> }; - chomp $v; + chomp($v = $git0->qx(qw(config --bool repack.writeBitmaps))); is($v, 'true', 'child repo inherited repack.writeBitmaps'); } -- 2.44.0