From fef8202d2e176bc93fce94c7be82ebab936a43da Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Fri, 18 Dec 2020 11:54:37 +0000 Subject: [PATCH] nntpd: skip inboxes w/o {newsgroup} So we don't trigger an uninitialized variable warning :x --- lib/PublicInbox/NNTPD.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/NNTPD.pm b/lib/PublicInbox/NNTPD.pm index 953228d0..7f9a1d58 100644 --- a/lib/PublicInbox/NNTPD.pm +++ b/lib/PublicInbox/NNTPD.pm @@ -38,8 +38,8 @@ sub refresh_groups { my $groups = $pi_cfg->{-by_newsgroup}; # filled during each_inbox $pi_cfg->each_inbox(sub { my ($ibx) = @_; - my $ngname = $ibx->{newsgroup}; - if (defined($ngname) && $ibx->nntp_usable) { + my $ngname = $ibx->{newsgroup} // return; + if ($ibx->nntp_usable) { # only valid if msgmap and over works # preload to avoid fragmentation: $ibx->description; -- 2.44.0