From ff53e6728ff67fef548f0f472c1918a00d7104f7 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Fri, 1 May 2020 18:04:45 +0000 Subject: [PATCH] t/convert-compact: avoid warning on `scalar(split(...))' Perl 5.10.1 would warn about implicit assignment to @_ by split(). So favor the documented method of using `tr' to count lines. Fixes: b5ddcb3352ef31ae ("index: support --compact / -c on command-line") --- t/convert-compact.t | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/t/convert-compact.t b/t/convert-compact.t index ae299021..1627e019 100644 --- a/t/convert-compact.t +++ b/t/convert-compact.t @@ -124,7 +124,6 @@ $rdr->{2} = \(my $err2 = ''); $cmd = [ qw(-index --reindex -cc), "$tmpdir/v2" ]; ok(run_script($cmd, undef, $rdr), '--reindex -c -c'); like($err2, qr/xapian-compact/, 'xapian-compact ran (-c -c)'); -ok(scalar(split(/\n/, $err2)) > scalar(split(/\n/, $err)), - '-compacted twice'); +ok(($err2 =~ tr/\n/\n/) > ($err =~ tr/\n/\n/), '-compacted twice'); done_testing(); -- 2.44.0