-# Copyright (C) 2019 all contributors <meta@public-inbox.org>
+# Copyright (C) 2019-2021 all contributors <meta@public-inbox.org>
# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
package PublicInbox::Tmpfile;
use strict;
-use warnings;
-use base qw(Exporter);
+use v5.10.1;
+use parent qw(Exporter);
our @EXPORT = qw(tmpfile);
use Fcntl qw(:DEFAULT);
use Errno qw(EEXIST);
-require File::Spec;
+use File::Spec;
# use tmpfile instead of open(..., '+>', undef) so we can get an
# unlinked filename which makes sense when viewed with lsof
# (at least on Linux)
-# TODO: O_APPEND support (this is the reason I'm not using File::Temp)
# And if we ever stop caring to have debuggable filenames, O_TMPFILE :)
-sub tmpfile ($;$) {
- my ($id, $sock) = @_;
+#
+# This is also for Perl <5.32 which lacks: open(..., '+>>', undef)
+# <https://rt.perl.org/Ticket/Display.html?id=134221>
+sub tmpfile ($;$$) {
+ my ($id, $sock, $append) = @_;
if (defined $sock) {
# add the socket inode number so we can figure out which
# socket it belongs to
$id =~ tr!/!^!;
my $fl = O_RDWR | O_CREAT | O_EXCL;
+ $fl |= O_APPEND if $append;
do {
my $fn = File::Spec->tmpdir . "/$id-".time.'-'.rand;
if (sysopen(my $fh, $fn, $fl, 0600)) { # likely
- unlink($fn) or die "unlink($fn): $!"; # FS broken
+ unlink($fn) or warn "unlink($fn): $!"; # FS broken
return $fh; # success
}
} while ($! == EEXIST);