X-Git-Url: http://www.git.stargrave.org/?a=blobdiff_plain;f=lib%2FPublicInbox%2FLeiToMail.pm;h=3f65e9e99f5d1f9ac0a2250adb31a934d9f19532;hb=757652fd1ad6843c984610263a2a0b336c974111;hp=1f6c2a3b69da18265cfc45ef9173d341f467eae5;hpb=c2145231a10937edb7bc74a3b70fcb3d11938de3;p=public-inbox.git diff --git a/lib/PublicInbox/LeiToMail.pm b/lib/PublicInbox/LeiToMail.pm index 1f6c2a3b..3f65e9e9 100644 --- a/lib/PublicInbox/LeiToMail.pm +++ b/lib/PublicInbox/LeiToMail.pm @@ -17,7 +17,7 @@ use PublicInbox::GitAsyncCat; use Symbol qw(gensym); use IO::Handle; # ->autoflush use Fcntl qw(SEEK_SET SEEK_END O_CREAT O_EXCL O_WRONLY); -use Errno qw(EEXIST ESPIPE ENOENT); +use Errno qw(EEXIST ESPIPE ENOENT EPIPE); # struggles with short-lived repos, Gcf2Client makes little sense with lei; # but we may use in-process libgit2 in the future. @@ -68,14 +68,16 @@ sub _mbox_hdr_buf ($$$) { } sub atomic_append { # for on-disk destinations (O_APPEND, or O_EXCL) - my ($fh, $buf) = @_; - defined(my $w = syswrite($fh, $$buf)) or die "write: $!"; - $w == length($$buf) or die "short write: $w != ".length($$buf); -} - -sub _print_full { - my ($fh, $buf) = @_; - print $fh $$buf or die "print: $!"; + my ($lei, $buf) = @_; + if (defined(my $w = syswrite($lei->{1} // return, $$buf))) { + return if $w == length($$buf); + $buf = "short atomic write: $w != ".length($$buf); + } elsif ($! == EPIPE) { + return $lei->note_sigpipe(1); + } else { + $buf = "atomic write: $!"; + } + $lei->fail($buf); } sub eml2mboxrd ($;$) { @@ -209,10 +211,10 @@ sub zsfx2cmd ($$$) { } sub _post_augment_mbox { # open a compressor process - my ($self, $lei, $zpipe) = @_; + my ($self, $lei) = @_; my $zsfx = $self->{zsfx} or return; my $cmd = zsfx2cmd($zsfx, undef, $lei); - my ($r, $w) = splice(@$zpipe, 0, 2); + my ($r, $w) = @{delete $lei->{zpipe}}; my $rdr = { 0 => $r, 1 => $lei->{1}, 2 => $lei->{2} }; my $pid = spawn($cmd, $lei->{env}, $rdr); my $pp = gensym; @@ -248,24 +250,19 @@ sub _mbox_write_cb ($$) { my $ovv = $lei->{ovv}; my $m = 'eml2'.$ovv->{fmt}; my $eml2mbox = $self->can($m) or die "$self->$m missing"; - my $out = $lei->{1} // die "no stdout ($m, $ovv->{dst})"; # redirected earlier - $out->autoflush(1); - my $write = $ovv->{lock_path} ? \&_print_full : \&atomic_append; + $lei->{1} // die "no stdout ($m, $ovv->{dst})"; # redirected earlier + $lei->{1}->autoflush(1); + my $atomic_append = !defined($ovv->{lock_path}); my $dedupe = $lei->{dedupe}; $dedupe->prepare_dedupe; sub { # for git_to_mail my ($buf, $smsg, $eml) = @_; - return unless $out; $eml //= PublicInbox::Eml->new($buf); - if (!$dedupe->is_dup($eml, $smsg->{blob})) { - $buf = $eml2mbox->($eml, $smsg); - my $lk = $ovv->lock_for_scope; - eval { $write->($out, $buf) }; - if ($@) { - die $@ if ref($@) ne 'PublicInbox::SIGPIPE'; - undef $out - } - } + return if $dedupe->is_dup($eml, $smsg->{blob}); + $buf = $eml2mbox->($eml, $smsg); + return atomic_append($lei, $buf) if $atomic_append; + my $lk = $ovv->lock_for_scope; + $lei->out($$buf); } } @@ -299,14 +296,14 @@ sub _buf2maildir { my $kw = $smsg->{kw} // []; my $sfx = join('', sort(map { $kw2char{$_} // () } @$kw)); my $rand = ''; # chosen by die roll :P - my ($tmp, $fh, $final); + my ($tmp, $fh, $final, $ok); my $common = $smsg->{blob} // _rand; if (defined(my $pct = $smsg->{pct})) { $common .= "=$pct" } do { $tmp = $dst.'tmp/'.$rand.$common; - } while (!sysopen($fh, $tmp, O_CREAT|O_EXCL|O_WRONLY) && + } while (!($ok = sysopen($fh, $tmp, O_CREAT|O_EXCL|O_WRONLY)) && $! == EEXIST && ($rand = _rand.',')); - if (print $fh $$buf and close($fh)) { + if ($ok && print $fh $$buf and close($fh)) { # ignore new/ and write only to cur/, otherwise MUAs # with R/W access to the Maildir will end up doing # a mass rename which can take a while with thousands @@ -319,9 +316,10 @@ sub _buf2maildir { ($rand = _rand.',')); unlink($tmp) or warn "W: failed to unlink $tmp: $!\n"; } else { - my $err = $!; + my $err = "Error writing $smsg->{blob} to $dst: $!\n"; + $_[0] = undef; # clobber dst unlink($tmp); - die "Error writing $smsg->{blob} to $dst: $err"; + die $err; } } @@ -332,6 +330,7 @@ sub _maildir_write_cb ($$) { my $dst = $lei->{ovv}->{dst}; sub { # for git_to_mail my ($buf, $smsg, $eml) = @_; + $dst // return $lei->fail; # dst may be undef-ed in last run $buf //= \($eml->as_string); return _buf2maildir($dst, $buf, $smsg) if !$dedupe; $eml //= PublicInbox::Eml->new($$buf); # copy buf @@ -366,6 +365,7 @@ sub new { } else { die "bad mail --format=$fmt\n"; } + $self->{dst} = $dst; $lei->{dedupe} = PublicInbox::LeiDedupe->new($lei); $self; } @@ -408,7 +408,7 @@ sub _pre_augment_mbox { $! == ENOENT or die "unlink($dst): $!"; } open my $out, $mode, $dst or die "open($dst): $!"; - $lei->{old_1} = $lei->{1}; + $lei->{old_1} = $lei->{1}; # keep for spawning MUA $lei->{1} = $out; } # Perl does SEEK_END even with O_APPEND :< @@ -419,7 +419,7 @@ sub _pre_augment_mbox { state $zsfx_allow = join('|', keys %zsfx2cmd); ($self->{zsfx}) = ($dst =~ /\.($zsfx_allow)\z/) or return; pipe(my ($r, $w)) or die "pipe: $!"; - [ $r, $w ]; + $lei->{zpipe} = [ $r, $w ]; } sub _do_augment_mbox { @@ -463,17 +463,36 @@ sub post_augment { # fast (spawn compressor or mkdir), runs in main daemon $self->$m($lei, @args); } -sub write_mail { # via ->wq_do - my ($self, $git_dir, $smsg, $lei) = @_; - my $not_done = delete $self->{$lei->{each_smsg_not_done}}; - my $wcb = $self->{wcb} //= do { # first message - my %sig = $lei->atfork_child_wq($self); - @SIG{keys %sig} = values %sig; # not local - $self->write_cb($lei); - }; +sub ipc_atfork_child { + my ($self) = @_; + my $lei = delete $self->{lei}; + $lei->lei_atfork_child; + if (my $zpipe = delete $lei->{zpipe}) { + $lei->{1} = $zpipe->[1]; + close $zpipe->[0]; + } + $self->{wcb} = $self->write_cb($lei); + $SIG{__WARN__} = PublicInbox::Eml::warn_ignore_cb(); + $self->SUPER::ipc_atfork_child; +} + +sub lock_free { + $_[0]->{base_type} =~ /\A(?:maildir|mh|imap|jmap)\z/ ? 1 : 0; +} + +sub poke_dst { + my ($self) = @_; + if ($self->{base_type} eq 'maildir') { + my $t = time + 1; + utime($t, $t, "$self->{dst}/cur"); + } +} + +sub write_mail { # via ->wq_io_do + my ($self, $git_dir, $smsg) = @_; my $git = $self->{"$$\0$git_dir"} //= PublicInbox::Git->new($git_dir); git_async_cat($git, $smsg->{blob}, \&git_to_mail, - [$wcb, $smsg, $not_done]); + [$self->{wcb}, $smsg]); } sub wq_atexit_child { @@ -483,7 +502,6 @@ sub wq_atexit_child { $git->async_wait_all; } $SIG{__WARN__} = 'DEFAULT'; - $SIG{PIPE} = 'DEFAULT'; } 1;