X-Git-Url: http://www.git.stargrave.org/?a=blobdiff_plain;f=lib%2FPublicInbox%2FView.pm;h=2b8e220bb2a7f3ca4628a261c49f0efce04b4250;hb=bedc22c355d570ed07ff6600717a97226f791ff5;hp=466ec6cfdad1c0677211878498d0db288e170247;hpb=be55542acc90572da54d828313c2416ae1c902b1;p=public-inbox.git diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index 466ec6cf..2b8e220b 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -20,6 +20,7 @@ use PublicInbox::WwwStream qw(html_oneshot); use PublicInbox::Reply; use PublicInbox::ViewDiff qw(flush_diff); use PublicInbox::Eml; +use POSIX qw(strftime); use Time::Local qw(timegm); use PublicInbox::Smsg qw(subject_normalized); use PublicInbox::ContentHash qw(content_hash); @@ -37,7 +38,7 @@ sub msg_page_i { : $ctx->gone('over'); $ctx->{mhref} = ($ctx->{nr} || $ctx->{smsg}) ? "../${\mid_href($smsg->{mid})}/" : ''; - my $obuf = $ctx->{obuf} = _msg_page_prepare_obuf($eml, $ctx); + my $obuf = _msg_page_prepare_obuf($eml, $ctx); if (length($$obuf)) { multipart_text_as_html($eml, $ctx); $$obuf .= '
WARNING: multiple messages have this Message-ID\n"; - $rv .= '
'; +"WARNING: multiple messages have this Message-ID\n"; } else { $ctx->{first_hdr} = $eml->header_obj; $ctx->{chash} = content_hash($eml) if $ctx->{smsg}; # reused MID $rv .= "EOM } if ($ctx->{ibx}->over) { @@ -1161,9 +1166,10 @@ sub dump_topics { } my @out; - my $ibx = $ctx->{ibx}; - my $obfs_ibx = $ibx->{obfuscate} ? $ibx : undef; - + my $obfs_ibx = $ctx->{ibx}->{obfuscate} ? $ctx->{ibx} : undef; + if (my $note = delete $ctx->{t_note}) { + push @out, $note; # "messages from ... to ..." + } # sort by recency, this allows new posts to "bump" old topics... foreach my $topic (sort { $b->[0] <=> $a->[0] } @$order) { my ($ds, $n, $seen, $top_subj, @extra) = @$topic; @@ -1222,7 +1228,7 @@ sub pagination_footer ($$) { $next = $next ? "$next | " : ' | '; $prev .= qq[ | latest]; } - ($next || $prev) ? ""; # anchor for body start } - $ctx->{-upfx} = '../' if $over; + $ctx->{-upfx} = '../'; my @title; # (Subject[0], From[0]) for my $v ($eml->header('From')) { my @n = PublicInbox::Address::names($v); @@ -703,7 +703,7 @@ sub _msg_page_prepare_obuf { my $v = ascii_html(shift @subj); obfuscate_addrs($obfs_ibx, $v) if $obfs_ibx; $rv .= 'Subject: '; - $rv .= $over ? qq($v\n) : "$v\n"; + $rv .= $have_over ? qq($v\n) : "$v\n"; $title[0] = $v; for $v (@subj) { # multi-Subject message :< $v = ascii_html($v); @@ -711,34 +711,40 @@ sub _msg_page_prepare_obuf { $rv .= "Subject: $v\n"; } } else { # dummy anchor for thread skeleton at bottom of page - $rv .= qq() if $over; + $rv .= qq() if $have_over; $title[0] = '(no subject)'; } for my $v ($eml->header('Date')) { $v = ascii_html($v); obfuscate_addrs($obfs_ibx, $v) if $obfs_ibx; # possible :P - $rv .= qq{Date: $v\t[thread overview]\n}; + $rv .= qq{Date: $v\n}; + } + # [thread overview] link is typically added after Date, + # but added after Subject, or even nothing. + if ($have_over) { + chop $rv; # drop "\n", or noop if $rv eq '' + $rv .= qq{\t[thread overview]\n}; } if (!$nr) { # first (and only) message, common case $ctx->{-title_html} = join(' - ', @title); $rv = $ctx->html_top . $rv; } + + $ctx->{-linkify} //= PublicInbox::Linkify->new; if (scalar(@$mids) == 1) { # common case my $mhtml = ascii_html($mids->[0]); - $rv .= "Message-ID: <$mhtml> "; - $rv .= "(raw)\n"; + $rv .= qq[Message-ID: <$mhtml> (raw)\n]; } else { # X-Alt-Message-ID can happen if a message is injected from # public-inbox-nntpd because of multiple Message-ID headers. - my $lnk = PublicInbox::Linkify->new; my $s = ''; for my $h (qw(Message-ID X-Alt-Message-ID)) { $s .= "$h: $_\n" for ($eml->header_raw($h)); } - $lnk->linkify_mids('..', \$s, 1); + $ctx->{-linkify}->linkify_mids('..', \$s, 1); $rv .= $s; } - $rv .= _parent_headers($eml, $over); + _parent_headers($ctx, $eml); $rv .= "\n"; \$rv; } @@ -777,7 +783,6 @@ sub thread_skel ($$$) { # when multiple Subject: headers are present, so we follow suit: my $subj = $hdr->header('Subject') // ''; $subj = '(no subject)' if $subj eq ''; - $ctx->{prev_subj} = [ split(/ /, subject_normalized($subj)) ]; $ctx->{cur} = $mid; $ctx->{prev_attr} = ''; $ctx->{prev_level} = 0; @@ -791,35 +796,35 @@ sub thread_skel ($$$) { } sub _parent_headers { - my ($hdr, $over) = @_; - my $rv = ''; + my ($ctx, $hdr) = @_; my @irt = $hdr->header_raw('In-Reply-To'); my $refs; if (@irt) { - my $lnk = PublicInbox::Linkify->new; - $rv .= "In-Reply-To: $_\n" for @irt; - $lnk->linkify_mids('..', \$rv); + my $s = ''; + $s .= "In-Reply-To: $_\n" for @irt; + $ctx->{-linkify}->linkify_mids('..', \$s); + ${$ctx->{obuf}} .= $s; } else { $refs = references($hdr); my $irt = pop @$refs; if (defined $irt) { my $html = ascii_html($irt); my $href = mid_href($irt); - $rv .= "In-Reply-To: <"; - $rv .= "$html>\n"; + ${$ctx->{obuf}} .= <+/>\t(help)$html> +EOM } } # do not display References: if search is present, # we show the thread skeleton at the bottom, instead. - return $rv if $over; + return if $ctx->{ibx}->over; $refs //= references($hdr); if (@$refs) { - @$refs = map { linkify_ref_no_over($_) } @$refs; - $rv .= 'References: '. join("\n\t", @$refs) . "\n"; + $_ = linkify_ref_no_over($_) for @$refs; + ${$ctx->{obuf}} .= 'References: '. join("\n\t", @$refs) . "\n"; } - $rv; } # returns a string buffer @@ -849,7 +854,7 @@ action=$upfx href=#t>this message: \t(help) page: $next$prev" : ''; + ($next || $prev) ? "page: $next$prev" : ''; } sub paginate_recent ($$) { @@ -1238,21 +1244,29 @@ sub paginate_recent ($$) { $t =~ /\A([0-9]{8,14})\z/ and $before = str2ts($1); my $msgs = $ctx->{ibx}->over->recent($opts, $after, $before); - my $nr = scalar @$msgs; - if ($nr < $lim && defined($after)) { + if (defined($after) && scalar(@$msgs) < $lim) { $after = $before = undef; $msgs = $ctx->{ibx}->over->recent($opts); - $nr = scalar @$msgs; } - my $more = $nr == $lim; + my $more = scalar(@$msgs) == $lim; my ($newest, $oldest); - if ($nr) { + if (@$msgs) { $newest = $msgs->[0]->{ts}; $oldest = $msgs->[-1]->{ts}; # if we only had $after, our SQL query in ->recent ordered if ($newest < $oldest) { ($oldest, $newest) = ($newest, $oldest); - $more = 0 if defined($after) && $after < $oldest; + $more = undef if defined($after) && $after < $oldest; + } + if (defined($after // $before)) { + my $n = strftime('%Y-%m-%d %H:%M:%S', gmtime($newest)); + my $o = strftime('%Y-%m-%d %H:%M:%S', gmtime($oldest)); + $ctx->{t_note} = <more...] +EOM + my $s = ts2str($newest); + $ctx->{prev_page} = qq[] . + 'prev (newer)'; } } if (defined($oldest) && $more) { @@ -1260,11 +1274,6 @@ sub paginate_recent ($$) { $ctx->{next_page} = qq[] . 'next (older)'; } - if (defined($newest) && (defined($before) || defined($after))) { - my $s = ts2str($newest); - $ctx->{prev_page} = qq[] . - 'prev (newer)'; - } $msgs; }