X-Git-Url: http://www.git.stargrave.org/?a=blobdiff_plain;f=lib%2FPublicInbox%2FViewVCS.pm;h=e0fdf63999c20aaf7e3ce58442d1a12b3b3d15f2;hb=16f317f32bd5306d852b7d079b20cd0e4f2b4ff9;hp=b04a5672028e226ad66a2c50bd89687092b27387;hpb=7dafd481c3e4252447b6b7cf4f4a8d4620d1cc10;p=public-inbox.git diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm index b04a5672..e0fdf639 100644 --- a/lib/PublicInbox/ViewVCS.pm +++ b/lib/PublicInbox/ViewVCS.pm @@ -21,10 +21,12 @@ use PublicInbox::GitAsyncCat; use PublicInbox::WwwStream qw(html_oneshot); use PublicInbox::Linkify; use PublicInbox::Tmpfile; -use PublicInbox::ViewDiff qw(flush_diff); +use PublicInbox::ViewDiff qw(flush_diff uri_escape_path); use PublicInbox::View; +use PublicInbox::Eml; use Text::Wrap qw(wrap); -use PublicInbox::Hval qw(ascii_html to_filename); +use PublicInbox::Hval qw(ascii_html to_filename prurl); +use POSIX qw(strftime); my $hl = eval { require PublicInbox::HlMod; PublicInbox::HlMod->new; @@ -33,14 +35,22 @@ my $hl = eval { my %QP_MAP = ( A => 'oid_a', a => 'path_a', b => 'path_b' ); our $MAX_SIZE = 1024 * 1024; # TODO: configurable my $BIN_DETECT = 8000; # same as git -my $SHOW_FMT = '--pretty=format:'.join('%n', '%P', '%p', '%H', '%T', '%s', +my $SHOW_FMT = '--pretty=format:'.join('%n', '%P', '%p', '%H', '%T', '%s', '%f', '%an <%ae> %ai', '%cn <%ce> %ci', '%b%x00'); -sub html_page ($$$) { - my ($ctx, $code, $str) = @_; +my %GIT_MODE = ( + '100644' => ' ', # blob + '100755' => 'x', # executable blob + '040000' => 'd', # tree + '120000' => 'l', # symlink + '160000' => 'g', # commit (gitlink) +); + +sub html_page ($$;@) { + my ($ctx, $code) = @_[0, 1]; my $wcb = delete $ctx->{-wcb}; - $ctx->{-upfx} = '../../'; # from "/$INBOX/$OID/s/" - my $res = html_oneshot($ctx, $code, \$str); + $ctx->{-upfx} //= '../../'; # from "/$INBOX/$OID/s/" + my $res = html_oneshot($ctx, $code, @_[2..$#_]); $wcb ? $wcb->($res) : $res; } @@ -55,8 +65,9 @@ sub dbg_log ($) { warn "readline(log): $!"; return '
debug log read error
'; }; + return '' if $log eq ''; $ctx->{-linkify} //= PublicInbox::Linkify->new; - '
debug log:

'.
+	"
debug log:\n\n".
 		$ctx->{-linkify}->to_html($log).'
'; } @@ -90,11 +101,11 @@ sub stream_large_blob ($$) { my $cmd = ['git', "--git-dir=$git->{git_dir}", 'cat-file', $type, $oid]; my $qsp = PublicInbox::Qspawn->new($cmd); my $env = $ctx->{env}; - $env->{'qspawn.wcb'} = delete $ctx->{-wcb}; + $env->{'qspawn.wcb'} = $ctx->{-wcb}; $qsp->psgi_return($env, undef, \&stream_blob_parse_hdr, $ctx); } -sub show_other_result ($$) { # tag, tree, ... +sub show_other_result ($$) { # future-proofing my ($bref, $ctx) = @_; if (my $qsp_err = delete $ctx->{-qsp_err}) { return html_page($ctx, 500, dbg_log($ctx) . @@ -127,8 +138,7 @@ sub show_commit_start { # ->psgi_qx callback chop(my $buf = do { local $/ = "\0"; <$fh> }); chomp $buf; my ($P, $p); - ($P, $p, @$ctx{qw(cmt_H cmt_T cmt_s cmt_au cmt_co cmt_b)}) - = split(/\n/, $buf, 8); + ($P, $p, @{$ctx->{cmt_info}}) = split(/\n/, $buf, 9); return cmt_finalize($ctx) if !$P; @{$ctx->{-cmt_P}} = split(/ /, $P); @{$ctx->{-cmt_p}} = split(/ /, $p); # abbreviated @@ -144,11 +154,39 @@ sub show_commit_start { # ->psgi_qx callback } } +sub ibx_url_for { + my ($ctx) = @_; + $ctx->{ibx} and return; # fall back to $upfx + $ctx->{git} or die 'BUG: no {git}'; + if (my $ALL = $ctx->{www}->{pi_cfg}->ALL) { + if (defined(my $u = $ALL->base_url($ctx->{env}))) { + return wantarray ? ($u) : $u; + } + } + my @ret; + if (my $ibx_names = $ctx->{git}->{ibx_names}) { + my $by_name = $ctx->{www}->{pi_cfg}->{-by_name}; + for my $name (@$ibx_names) { + my $ibx = $by_name->{$name} // do { + warn "inbox `$name' no longer exists\n"; + next; + }; + $ibx->isrch // next; + my $u = defined($ibx->{url}) ? + prurl($ctx->{env}, $ibx->{url}) : $name; + $u .= '/' if substr($u, -1) ne '/'; + push @ret, $u; + } + } + wantarray ? (@ret) : $ret[0]; +} + sub cmt_finalize { my ($ctx) = @_; $ctx->{-linkify} //= PublicInbox::Linkify->new; + my $upfx = $ctx->{-upfx} = '../../'; # from "/$INBOX/$OID/s/" + my ($H, $T, $s, $f, $au, $co, $bdy) = @{delete $ctx->{cmt_info}}; # try to keep author and committer dates lined up - my ($au, $co) = delete @$ctx{qw(cmt_au cmt_co)}; my $x = length($au) - length($co); if ($x > 0) { $x = ' ' x $x; @@ -158,46 +196,49 @@ sub cmt_finalize { $au =~ s/>/>$x/; } $_ = ascii_html($_) for ($au, $co); - my $s = $ctx->{-linkify}->to_html(delete $ctx->{cmt_s}); - $ctx->{-title_html} = $s; - my $upfx = $ctx->{-upfx} = '../../'; # from "/$INBOX/$OID/s/" + $au =~ s!(> +)([0-9]{4,}-\S+ \S+)! + my ($gt, $t) = ($1, $2); + $t =~ tr/ :-//d; + qq($gt$2) + !e; + $ctx->{-title_html} = $s = $ctx->{-linkify}->to_html($s); my ($P, $p, $pt) = delete @$ctx{qw(-cmt_P -cmt_p -cmt_pt)}; $_ = qq().shift(@$p).' '.shift(@$pt) for @$P; if (@$P == 1) { - $x = qq(\n parent $P->[0]); + $x = qq{ (patch)\n parent $P->[0]}; } elsif (@$P > 1) { - $x = qq(\n parents $P->[0]\n); + $x = qq(\n parents $P->[0]\n); shift @$P; $x .= qq( $_\n) for @$P; chop $x; } else { - $x = ' (root commit)'; + $x = ' (root commit)'; } PublicInbox::WwwStream::html_init($ctx); - $ctx->zmore(< commit $ctx->{cmt_H}$x - tree $ctx->{cmt_T} + my $zfh = $ctx->zfh; + print $zfh < commit $H$x + tree $T author $au committer $co $s EOM - $x = delete $ctx->{cmt_b}; - $ctx->zmore("\n", $ctx->{-linkify}->to_html($x)) if length($x); - undef $x; + print $zfh "\n", $ctx->{-linkify}->to_html($bdy) if length($bdy); + $bdy = ''; open my $fh, '<:utf8', "$ctx->{-tmp}/p" or die "open $ctx->{-tmp}/p: $!"; if (-s $fh > $MAX_SIZE) { - $ctx->zmore("---\n patch is too large to show\n"); + print $zfh "---\n patch is too large to show\n"; } else { # prepare flush_diff: - $ctx->{obuf} = \$x; + read($fh, $x, -s _); $ctx->{-apfx} = $ctx->{-spfx} = $upfx; - read($fh, my $bdy, -s _); - $bdy =~ s/\r?\n/\n/gs; - $ctx->{-anchors} = {} if $bdy =~ /^diff --git /sm; - flush_diff($ctx, \$bdy); # undefs $bdy - $ctx->zmore($x); - undef $x; + $x =~ s/\r?\n/\n/gs; + $ctx->{-anchors} = {} if $x =~ /^diff --git /sm; + flush_diff($ctx, \$x); # undefs $x # TODO: should there be another textarea which attempts to # search for the exact email which was applied to make this # commit? @@ -215,23 +256,81 @@ EOM $q = wrap('', '', $q); my $rows = ($q =~ tr/\n/\n/) + 1; $q = ascii_html($q); - $ctx->zmore(<
find related emails, including ancestors/descendants/conflicts
 
-\t(help)
+\t(help)
EOM } } - $x = $ctx->zflush($ctx->_html_end); - my $res_hdr = delete $ctx->{-res_hdr}; - push @$res_hdr, 'Content-Length', length($x); - delete($ctx->{env}->{'qspawn.wcb'})->([200, $res_hdr, [$x]]); + chop($x = <
glossary
+--------
+Commit objects reference one tree, and zero or more parents.
+
+Single parent commits can typically generate a patch in
+unified diff format via `git format-patch'.
+
+Multiple parents means the commit is a merge.
+
+Root commits have no ancestor.  Note that it is
+possible to have multiple root commits when merging independent histories.
+
+Every commit references one top-level tree object.
+EOM + delete($ctx->{-wcb})->($ctx->html_done($x)); +} + +sub stream_patch_parse_hdr { # {parse_hdr} for Qspawn + my ($r, $bref, $ctx) = @_; + if (!defined $r) { # sysread error + html_page($ctx, 500, dbg_log($ctx)); + } elsif (index($$bref, "\n\n") >= 0) { + my $eml = bless { hdr => $bref }, 'PublicInbox::Eml'; + my $fn = to_filename($eml->header('Subject') // ''); + $fn = substr($fn // 'PATCH-no-subject', 6); # drop "PATCH-" + return [ 200, [ 'Content-Type', 'text/plain; charset=UTF-8', + 'Content-Disposition', + qq(inline; filename=$fn.patch) ] ]; + } elsif ($r == 0) { + my $log = dbg_log($ctx); + warn "premature EOF on $ctx->{patch_oid} $log"; + return html_page($ctx, 500, $log); + } else { + undef; # bref keeps growing until "\n\n" + } +} + +sub show_patch ($$) { + my ($ctx, $res) = @_; + my ($git, $oid) = @$res; + my @cmd = ('git', "--git-dir=$git->{git_dir}", + qw(format-patch -1 --stdout -C), + "--signature=git format-patch -1 --stdout -C $oid", $oid); + my $qsp = PublicInbox::Qspawn->new(\@cmd); + $ctx->{env}->{'qspawn.wcb'} = $ctx->{-wcb}; + $ctx->{patch_oid} = $oid; + $qsp->psgi_return($ctx->{env}, undef, \&stream_patch_parse_hdr, $ctx); } sub show_commit ($$) { my ($ctx, $res) = @_; + return show_patch($ctx, $res) if ($ctx->{fn} // '') =~ /\.patch\z/; my ($git, $oid) = @$res; # patch-id needs two passes, and we use the initial show to ensure # a patch embedded inside the commit message body doesn't get fed @@ -245,16 +344,16 @@ sub show_commit ($$) { my $e = { GIT_DIR => $git->{git_dir} }; my $qsp = PublicInbox::Qspawn->new($cmd, $e, { -C => "$ctx->{-tmp}" }); $qsp->{qsp_err} = \($ctx->{-qsp_err} = ''); - $ctx->{env}->{'qspawn.wcb'} = delete $ctx->{-wcb}; + $ctx->{env}->{'qspawn.wcb'} = $ctx->{-wcb}; $ctx->{git} = $git; $qsp->psgi_qx($ctx->{env}, undef, \&show_commit_start, $ctx); } -sub show_other ($$) { +sub show_other ($$) { # just in case... my ($ctx, $res) = @_; my ($git, $oid, $type, $size) = @$res; $size > $MAX_SIZE and return html_page($ctx, 200, - "$oid is too big to show\n". dbg_log($ctx)); + ascii_html($type)." $oid is too big to show\n". dbg_log($ctx)); my $cmd = ['git', "--git-dir=$git->{git_dir}", qw(show --encoding=UTF-8 --no-color --no-abbrev), $oid ]; my $qsp = PublicInbox::Qspawn->new($cmd); @@ -262,6 +361,126 @@ sub show_other ($$) { $qsp->psgi_qx($ctx->{env}, undef, \&show_other_result, $ctx); } +sub show_tree_result ($$) { + my ($bref, $ctx) = @_; + if (my $qsp_err = delete $ctx->{-qsp_err}) { + return html_page($ctx, 500, dbg_log($ctx) . + "git ls-tree -z error:$qsp_err"); + } + my @ent = split(/\0/, $$bref); + my $qp = delete $ctx->{qp}; + my $l = $ctx->{-linkify} //= PublicInbox::Linkify->new; + my $pfx = $ctx->{-path} // $qp->{b}; # {-path} is from RepoTree + $$bref = "
tree $ctx->{tree_oid}";
+	# $REPO/tree/$path already sets {-upfx}
+	my $upfx = $ctx->{-upfx} //= '../../';
+	if (defined $pfx) {
+		$pfx =~ s!/+\z!!s;
+		if (my $t = $ctx->{-obj}) {
+			my $t = ascii_html($t);
+			$$bref .= <path: $x\n);
+		}
+	} else {
+		$pfx = '';
+		$$bref .= qq[  (path unknown)\n];
+	}
+	my ($x, $m, $t, $oid, $sz, $f, $n);
+	$$bref .= "\n	size	name";
+	for (@ent) {
+		($x, $f) = split(/\t/, $_, 2);
+		undef $_;
+		($m, $t, $oid, $sz) = split(/ +/, $x, 4);
+		$m = $GIT_MODE{$m} // '?';
+		utf8::decode($f);
+		$n = ascii_html($f);
+		if ($m eq 'g') { # gitlink submodule commit
+			$$bref .= "\ng\t\t$n @ commit$oid";
+			next;
+		}
+		my $q = 'b='.ascii_html(uri_escape_path($pfx.$f));
+		if ($m eq 'd') { $n .= '/' }
+		elsif ($m eq 'x') { $n = "$n" }
+		elsif ($m eq 'l') { $n = "$n" }
+		$$bref .= qq(\n$m\t$sz\t$n);
+	}
+	$$bref .= dbg_log($ctx);
+	$$bref .= <glossary
+--------
+Tree objects belong to commits or other tree objects.  Trees may
+reference blobs, sub-trees, or commits of submodules.
+
+Path names are stored in tree objects, but trees do not know
+their own path name.  A tree's path name comes from their parent tree,
+or it is the root tree referenced by a commit object.  Thus, this web UI
+relies on the `b=' URI parameter as a hint to display the path name.
+
+Commit objects may be stored in trees to reference submodules.
+EOM + chop $$bref; + html_page($ctx, 200, $$bref); +} + +sub show_tree ($$) { # also used by RepoTree + my ($ctx, $res) = @_; + my ($git, $oid, undef, $size) = @$res; + $size > $MAX_SIZE and return html_page($ctx, 200, + "tree $oid is too big to show\n". dbg_log($ctx)); + my $cmd = [ 'git', "--git-dir=$git->{git_dir}", + qw(ls-tree -z -l --no-abbrev), $oid ]; + my $qsp = PublicInbox::Qspawn->new($cmd); + $ctx->{tree_oid} = $oid; + $qsp->{qsp_err} = \($ctx->{-qsp_err} = ''); + $qsp->psgi_qx($ctx->{env}, undef, \&show_tree_result, $ctx); +} + +# returns seconds offset from git TZ offset +sub tz_adj ($) { + my ($tz) = @_; # e.g "-0700" + $tz = int($tz); + my $mm = $tz < 0 ? -$tz : $tz; + $mm = int($mm / 100) * 60 + ($mm % 100); + $mm = $tz < 0 ? -$mm : $mm; + ($mm * 60); +} + +sub show_tag_result { # git->cat_async callback + my ($bref, $oid, $type, $size, $ctx) = @_; + utf8::decode($$bref); + my $l = PublicInbox::Linkify->new; + $$bref = $l->to_html($$bref); + $$bref =~ s!^object ([a-f0-9]+)!object $1!; + + $$bref =~ s/^(tagger .*> )([0-9]+) ([\-+]?[0-9]+)/$1.strftime( + '%Y-%m-%d %H:%M:%S', gmtime($2 + tz_adj($3)))." $3"/sme; + # TODO: download link + html_page($ctx, 200, '
', $$bref, '
', dbg_log($ctx)); +} + +sub show_tag ($$) { + my ($ctx, $res) = @_; + my ($git, $oid) = @$res; + $ctx->{git} = $git; + if ($ctx->{env}->{'pi-httpd.async'}) { + ibx_async_cat($ctx, $oid, \&show_tag_result, $ctx); + } else { # synchronous (generic PSGI) + $git->cat_async($oid, \&show_tag_result, $ctx); + $git->cat_async_wait; + } +} + # user_cb for SolverGit, called as: user_cb->($result_or_error, $uarg) sub solve_result { my ($res, $ctx) = @_; @@ -271,21 +490,37 @@ sub solve_result { my ($git, $oid, $type, $size, $di) = @$res; return show_commit($ctx, $res) if $type eq 'commit'; + return show_tree($ctx, $res) if $type eq 'tree'; + return show_tag($ctx, $res) if $type eq 'tag'; return show_other($ctx, $res) if $type ne 'blob'; - my $path = to_filename($di->{path_b} // $hints->{path_b} // 'blob'); - my $raw_link = "(raw)"; + my $paths = $ctx->{-paths} //= do { + my $path = to_filename($di->{path_b}//$hints->{path_b}//'blob'); + my $raw_more = qq[(raw)]; + [ $path, $raw_more ]; + }; + if ($size > $MAX_SIZE) { return stream_large_blob($ctx, $res) if defined $ctx->{fn}; return html_page($ctx, 200, <Too big to show, download available -"$oid $type $size bytes $raw_link +blob $oid $size bytes $paths->[1] EOM } + bless $ctx, 'PublicInbox::WwwStream'; # for DESTROY + $ctx->{git} = $git; + if ($ctx->{env}->{'pi-httpd.async'}) { + ibx_async_cat($ctx, $oid, \&show_blob, $ctx); + } else { # synchronous + $git->cat_async($oid, \&show_blob, $ctx); + $git->cat_async_wait; + } +} - my $blob = $git->cat_file($oid); - if (!$blob) { # WTF? +sub show_blob { # git->cat_async callback + my ($blob, $oid, $type, $size, $ctx) = @_; + if (!$blob) { my $e = "Failed to retrieve generated blob ($oid)"; - warn "$e ($git->{git_dir})"; + warn "$e ($ctx->{git}->{git_dir}) type=$type"; return html_page($ctx, 500, "
$e
".dbg_log($ctx)) } @@ -296,9 +531,10 @@ EOM return delete($ctx->{-wcb})->([200, $h, [ $$blob ]]); } + my ($path, $raw_more) = @{delete $ctx->{-paths}}; $bin and return html_page($ctx, 200, - "
$oid $type $size bytes (binary)" .
-				" $raw_link
".dbg_log($ctx)); + "
blob $oid $size bytes (binary)" .
+				" $raw_more
".dbg_log($ctx)); # TODO: detect + convert to ensure validity utf8::decode($$blob); @@ -314,14 +550,14 @@ EOM } # using some of the same CSS class names and ids as cgit - html_page($ctx, 200, "
$oid $type $size bytes $raw_link
" . + my $x = "
blob $oid $size bytes $raw_more
" . "
". - "
" . join('', map {
-			sprintf("% ${pad}u\n", $_)
-		} (1..$nl)) . '
' . - '
 
'. # pad for non-CSS users - "" . - $ctx->{-linkify}->linkify_2($$blob) . + "
";
+	# scratchpad in this loop is faster here than `printf $zfh':
+	$x .= sprintf("% ${pad}u\n", $_) for (1..$nl);
+	$x .= '
 
'. # pad for non-CSS users + ""; + html_page($ctx, 200, $x, $ctx->{-linkify}->linkify_2($$blob), ''.dbg_log($ctx)); } @@ -340,6 +576,7 @@ sub show ($$;$) { open $ctx->{lh}, '+>>', "$ctx->{-tmp}/solve.log" or die "open: $!"; my $solver = PublicInbox::SolverGit->new($ctx->{ibx}, \&solve_result, $ctx); + $solver->{gits} //= [ $ctx->{git} ]; $solver->{tmp} = $ctx->{-tmp}; # share tmpdir # PSGI server will call this immediately and give us a callback (-wcb) sub {