X-Git-Url: http://www.git.stargrave.org/?a=blobdiff_plain;f=t%2Faddress.t;h=6f4bff6c42928f4707355d9c25b286f1e6dac042;hb=03c9119ec613fa43dcf0a50b5f35754f13228bc8;hp=be0fc5b7b41aa1eec50e8a130e7c8ace619cf4e4;hpb=5cbb8df04448baf6c07c3de652d287bd2a0a3299;p=public-inbox.git
diff --git a/t/address.t b/t/address.t
index be0fc5b7..6f4bff6c 100644
--- a/t/address.t
+++ b/t/address.t
@@ -1,36 +1,58 @@
-# Copyright (C) 2016 all contributors
+# Copyright (C) 2016-2020 all contributors
# License: AGPL-3.0+
use strict;
use warnings;
use Test::More;
use_ok 'PublicInbox::Address';
-is_deeply([qw(e@example.com e@example.org)],
- [PublicInbox::Address::emails('User , e@example.org')],
- 'address extraction works as expected');
-
-is_deeply([PublicInbox::Address::emails('"ex@example.com" ')],
- [qw(ex@example.com)]);
-
-my @names = PublicInbox::Address::names(
- 'User , e@e, "John A. Doe" , ');
-is_deeply(['User', 'e', 'John A. Doe', 'x'], \@names,
- 'name extraction works as expected');
-
-@names = PublicInbox::Address::names('"user@example.com" ');
-is_deeply(['user'], \@names, 'address-as-name extraction works as expected');
-
-
-{
- my $backwards = 'u@example.com (John Q. Public)';
- @names = PublicInbox::Address::names($backwards);
- is_deeply(\@names, ['u'], 'backwards name OK');
- my @emails = PublicInbox::Address::emails($backwards);
- is_deeply(\@emails, ['u@example.com'], 'backwards emails OK');
+sub test_pkg {
+ my ($pkg) = @_;
+ my $emails = \&{"${pkg}::emails"};
+ my $names = \&{"${pkg}::names"};
+
+ is_deeply([qw(e@example.com e@example.org)],
+ [$emails->('User , e@example.org')],
+ 'address extraction works as expected');
+
+ is_deeply(['user@example.com'],
+ [$emails->('')],
+ 'comment after domain accepted before >');
+
+ my @names = $names->(
+ 'User , e@e, "John A. Doe" , , (xyz), '.
+ 'U Ser (do not use)');
+ is_deeply(\@names, ['User', 'e', 'John A. Doe', 'x', 'xyz', 'U Ser'],
+ 'name extraction works as expected');
+
+ @names = $names->('"user@example.com" ');
+ is_deeply(['user'], \@names,
+ 'address-as-name extraction works as expected');
+
+ {
+ my $backwards = 'u@example.com (John Q. Public)';
+ @names = $names->($backwards);
+ is_deeply(\@names, ['John Q. Public'], 'backwards name OK');
+ my @emails = $emails->($backwards);
+ is_deeply(\@emails, ['u@example.com'], 'backwards emails OK');
+ }
+
+ @names = $names->('"Quote Unneeded" ');
+ is_deeply(['Quote Unneeded'], \@names, 'extra quotes dropped');
+
+ my @emails = $emails->('Local User ');
+ is_deeply([], \@emails , 'no address for local address');
+ @names = $emails->('Local User ');
+ is_deeply([], \@names, 'no address, no name');
}
+test_pkg('PublicInbox::Address');
-@names = PublicInbox::Address::names('"Quote Unneeded" ');
-is_deeply(['Quote Unneeded'], \@names, 'extra quotes dropped');
+SKIP: {
+ if ($INC{'PublicInbox/AddressPP.pm'}) {
+ skip 'Email::Address::XS missing', 8;
+ }
+ use_ok 'PublicInbox::AddressPP';
+ test_pkg('PublicInbox::AddressPP');
+}
done_testing;