X-Git-Url: http://www.git.stargrave.org/?a=blobdiff_plain;f=t%2Fconfig.t;h=b7a4ceb62e030d1efbd31c4ad53e7b0eec548cf6;hb=9bd675d33ad1e49bd2ebe12a1d216216e61380de;hp=437f1d145b868d35854ae54e2e3ef021590d2e79;hpb=bde2d8c8de65a4d6b06e8d7365f504f2d8db90a6;p=public-inbox.git
diff --git a/t/config.t b/t/config.t
index 437f1d14..b7a4ceb6 100644
--- a/t/config.t
+++ b/t/config.t
@@ -1,5 +1,5 @@
-# Copyright (C) 2014-2015 all contributors
-# License: AGPLv3 or later (https://www.gnu.org/licenses/agpl-3.0.txt)
+# Copyright (C) 2014-2019 all contributors
+# License: AGPL-3.0+
use strict;
use warnings;
use Test::More;
@@ -86,4 +86,108 @@ my $tmpdir = tempdir('pi-config-XXXXXX', TMPDIR => 1, CLEANUP => 1);
is($ibx->{nntpserver}, 'news.alt.example.com','per-inbox NNTP server');
}
+# no obfuscate domains
+{
+ my $pfx = "publicinbox.test";
+ my $pfx2 = "publicinbox.foo";
+ my %h = (
+ "$pfx.address" => 'test@example.com',
+ "$pfx.mainrepo" => '/path/to/non/existent',
+ "$pfx2.address" => 'foo@example.com',
+ "$pfx2.mainrepo" => '/path/to/foo',
+ lc("publicinbox.noObfuscate") =>
+ 'public-inbox.org @example.com z@EXAMPLE.com',
+ "$pfx.obfuscate" => 'true', # :<
+ );
+ my %tmp = %h;
+ my $cfg = PublicInbox::Config->new(\%tmp);
+ my $ibx = $cfg->lookup_name('test');
+ my $re = $ibx->{-no_obfuscate_re};
+ like('meta@public-inbox.org', $re,
+ 'public-inbox.org address not to be obfuscated');
+ like('t@example.com', $re, 'example.com address not to be obfuscated');
+ unlike('t@example.comM', $re, 'example.comM address does not match');
+ is_deeply($ibx->{-no_obfuscate}, {
+ 'test@example.com' => 1,
+ 'foo@example.com' => 1,
+ 'z@example.com' => 1,
+ }, 'known addresses populated');
+}
+
+my @invalid = (
+ # git rejects this because it locks refnames, but we don't have
+ # this problem with inbox names:
+ # 'inbox.lock',
+
+ # git rejects these:
+ '', '..', '.', 'stash@{9}', 'inbox.', '^caret', '~tilde',
+ '*asterisk', 's p a c e s', ' leading-space', 'trailing-space ',
+ 'question?', 'colon:', '[square-brace]', "\fformfeed",
+ "\0zero", "\bbackspace",
+
+);
+
+my %X = ("\0" => '\\0', "\b" => '\\b', "\f" => '\\f', "'" => "\\'");
+my $xre = join('|', keys %X);
+
+for my $s (@invalid) {
+ my $d = $s;
+ $d =~ s/($xre)/$X{$1}/g;
+ ok(!PublicInbox::Config::valid_inbox_name($s), "`$d' name rejected");
+}
+
+# obviously-valid examples
+my @valid = qw(a a@example a@example.com);
+
+# Rejecting more was considered, but then it dawned on me that
+# people may intentionally use inbox names which are not URL-friendly
+# to prevent the PSGI interface from displaying them...
+# URL-unfriendly
+# '<', '>', '%', '#', '?', '&', '(', ')',
+
+# maybe these aren't so bad, they're common in Message-IDs, even:
+# '!', '$', '=', '+'
+push @valid, qw[bang! ca$h less< more> 1% (parens) &more eql= +plus], '#hash';
+for my $s (@valid) {
+ ok(PublicInbox::Config::valid_inbox_name($s), "`$s' name accepted");
+}
+
+{
+ my $f = "$tmpdir/ordered";
+ open my $fh, '>', $f or die "open: $!";
+ my @expect;
+ foreach my $i (0..3) {
+ push @expect, "$i";
+ print $fh <<"" or die "print: $!";
+[publicinbox "$i"]
+ mainrepo = /path/to/$i.git
+ address = $i\@example.com
+
+ }
+ close $fh or die "close: $!";
+ my $cfg = PublicInbox::Config->new($f);
+ my @result;
+ $cfg->each_inbox(sub { push @result, $_[0]->{name} });
+ is_deeply(\@result, \@expect);
+}
+
+{
+ my $pfx1 = "publicinbox.test1";
+ my $pfx2 = "publicinbox.test2";
+ my $h = {
+ "$pfx1.address" => 'test@example.com',
+ "$pfx1.mainrepo" => '/path/to/non/existent',
+ "$pfx2.address" => 'foo@example.com',
+ "$pfx2.mainrepo" => '/path/to/foo',
+ "$pfx1.coderepo" => 'project',
+ "$pfx2.coderepo" => 'project',
+ "coderepo.project.dir" => '/path/to/project.git',
+ };
+ my $cfg = PublicInbox::Config->new($h);
+ my $t1 = $cfg->lookup_name('test1');
+ my $t2 = $cfg->lookup_name('test2');
+ is($t1->{-repo_objs}->[0], $t2->{-repo_objs}->[0],
+ 'inboxes share ::Git object');
+}
+
done_testing();