X-Git-Url: http://www.git.stargrave.org/?a=blobdiff_plain;f=t%2Fhttpd.t;h=849f61bb82ce3807c1b0372e2dfdc4a72ab1c168;hb=9cfb026469d5d94a0bbcbd11f6e0466db2aebfe1;hp=28f507db0d2da2bc48a964d619370c54ead1a63d;hpb=7dd78012da81d48e5e73e56c3255895dfa9de1f5;p=public-inbox.git
diff --git a/t/httpd.t b/t/httpd.t
index 28f507db..849f61bb 100644
--- a/t/httpd.t
+++ b/t/httpd.t
@@ -1,59 +1,27 @@
-# Copyright (C) 2016 all contributors
+#!perl -w
+# Copyright (C) 2016-2021 all contributors
# License: AGPL-3.0+
use strict;
-use warnings;
-use Test::More;
-
-foreach my $mod (qw(Plack::Util Plack::Request Plack::Builder Danga::Socket
- HTTP::Date HTTP::Status)) {
- eval "require $mod";
- plan skip_all => "$mod missing for httpd.t" if $@;
-}
-use File::Temp qw/tempdir/;
-use Cwd qw/getcwd/;
-use IO::Socket;
-use Fcntl qw(FD_CLOEXEC F_SETFD F_GETFD);
-use Socket qw(SO_KEEPALIVE IPPROTO_TCP TCP_NODELAY);
-use IPC::Run;
+use v5.10.1;
+use PublicInbox::TestCommon;
+use PublicInbox::Eml;
+use Socket qw(IPPROTO_TCP SOL_SOCKET);
+require_mods(qw(Plack::Util Plack::Builder HTTP::Date HTTP::Status));
# FIXME: too much setup
-my $tmpdir = tempdir('pi-httpd-XXXXXX', TMPDIR => 1, CLEANUP => 1);
+my ($tmpdir, $for_destroy) = tmpdir();
my $home = "$tmpdir/pi-home";
my $err = "$tmpdir/stderr.log";
my $out = "$tmpdir/stdout.log";
-my $pi_home = "$home/.public-inbox";
-my $pi_config = "$pi_home/config";
-my $maindir = "$tmpdir/main.git";
-my $main_bin = getcwd()."/t/main-bin";
-my $main_path = "$main_bin:$ENV{PATH}"; # for spamc ham mock
+my $inboxdir = "$tmpdir/i.git";
my $group = 'test-httpd';
my $addr = $group . '@example.com';
-my $cfgpfx = "publicinbox.$group";
-my $failbox = "$home/fail.mbox";
-local $ENV{PI_EMERGENCY} = $failbox;
-my $mda = 'blib/script/public-inbox-mda';
-my $httpd = 'blib/script/public-inbox-httpd';
-my $init = 'blib/script/public-inbox-init';
-
-my %opts = (
- LocalAddr => '127.0.0.1',
- ReuseAddr => 1,
- Proto => 'tcp',
- Type => SOCK_STREAM,
- Listen => 1024,
-);
-my $sock = IO::Socket::INET->new(%opts);
-my $pid;
-END { kill 'TERM', $pid if defined $pid };
+my $sock = tcp_server();
+my $td;
{
- local $ENV{HOME} = $home;
- ok(!system($init, $group, $maindir, 'http://example.com/', $addr),
- 'init ran properly');
-
- # ensure successful message delivery
- {
- local $ENV{ORIGINAL_RECIPIENT} = $addr;
- my $in = < $inboxdir, sub {
+ my ($im, $ibx) = @_;
+ $im->add(PublicInbox::Eml->new(<
To: You
Cc: $addr
@@ -63,37 +31,23 @@ Date: Thu, 01 Jan 1970 06:06:06 +0000
nntp
EOF
- local $ENV{PATH} = $main_path;
- IPC::Run::run([$mda], \$in);
- is(0, $?, 'ran MDA correctly');
- }
- ok($sock, 'sock created');
- $! = 0;
- my $fl = fcntl($sock, F_GETFD, 0);
- ok(! $!, 'no error from fcntl(F_GETFD)');
- is($fl, FD_CLOEXEC, 'cloexec set by default (Perl behavior)');
- $pid = fork;
- if ($pid == 0) {
- use POSIX qw(dup2);
- # pretend to be systemd
- fcntl($sock, F_SETFD, $fl &= ~FD_CLOEXEC);
- dup2(fileno($sock), 3) or die "dup2 failed: $!\n";
- $ENV{LISTEN_PID} = $$;
- $ENV{LISTEN_FDS} = 1;
- exec $httpd, "--stdout=$out", "--stderr=$err";
- die "FAIL: $!\n";
+ };
+ my $i2 = create_inbox 'test-2', sub {
+ my ($im, $ibx) = @_;
+ $im->add(eml_load('t/plack-qp.eml')) or xbail '->add';
+ };
+ local $ENV{HOME} = $home;
+ my $cmd = [ '-init', $group, $inboxdir, 'http://example.com/', $addr ];
+ ok(run_script($cmd), 'init ran properly');
+ $cmd = [ '-httpd', '-W0', "--stdout=$out", "--stderr=$err" ];
+ $td = start_script($cmd, undef, { 3 => $sock });
+ my $http_pfx = 'http://'.tcp_host_port($sock);
+ {
+ my $bad = tcp_connect($sock);
+ print $bad "GETT / HTTP/1.0\r\n\r\n" or die;
+ like(<$bad>, qr!\AHTTP/1\.[01] 405\b!, 'got 405 on bad req');
}
- ok(defined $pid, 'forked httpd process successfully');
- $! = 0;
- fcntl($sock, F_SETFD, $fl |= FD_CLOEXEC);
- ok(! $!, 'no error from fcntl(F_SETFD)');
- my $host = $sock->sockhost;
- my $port = $sock->sockport;
- my $conn = IO::Socket::INET->new(PeerAddr => $host,
- PeerPort => $port,
- Proto => 'tcp',
- Type => SOCK_STREAM);
- ok($conn, 'connected');
+ my $conn = tcp_connect($sock);
ok($conn->write("GET / HTTP/1.0\r\n\r\n"), 'wrote data to socket');
{
my $buf;
@@ -102,18 +56,62 @@ EOF
is($conn->read($buf, 1), 0, "EOF");
}
- is(system(qw(git clone -q --mirror),
- "http://$host:$port/$group", "$tmpdir/clone.git"),
+ is(xsys(qw(git clone -q --mirror),
+ "$http_pfx/$group", "$tmpdir/clone.git"),
+ 0, 'smart clone successful');
+
+ # ensure dumb cloning works, too:
+ is(xsys('git', "--git-dir=$inboxdir",
+ qw(config http.uploadpack false)),
+ 0, 'disable http.uploadpack');
+ is(xsys(qw(git clone -q --mirror),
+ "$http_pfx/$group", "$tmpdir/dumb.git"),
0, 'clone successful');
- ok(kill('TERM', $pid), 'killed httpd');
- $pid = undef;
- waitpid(-1, 0);
- is(system('git', "--git-dir=$tmpdir/clone.git",
+ # test config reload
+ my $cfg = "$home/.public-inbox/config";
+ open my $fh, '>>', $cfg or xbail "open: $!";
+ print $fh <{inboxdir}
+ address = test-2\@example.com
+ url = https://example.com/test-2
+EOM
+ close $fh or xbail "close $!";
+ $td->kill('HUP') or BAIL_OUT "failed to kill -httpd: $!";
+ tick; # wait for HUP to take effect
+ my $buf = do {
+ my $c2 = tcp_connect($sock);
+ $c2->write("GET /test-2/qp\@example.com/raw HTTP/1.0\r\n\r\n")
+ or xbail "c2 write: $!";
+ local $/;
+ <$c2>
+ };
+ like($buf, qr!\AHTTP/1\.0 200\b!s, 'got 200 after reload for test-2');
+
+ ok($td->kill, 'killed httpd');
+ $td->join;
+
+ is(xsys('git', "--git-dir=$tmpdir/clone.git",
qw(fsck --no-verbose)), 0,
'fsck on cloned directory successful');
}
-done_testing();
+SKIP: {
+ skip 'TCP_DEFER_ACCEPT is Linux-only', 1 if $^O ne 'linux';
+ my $var = eval { Socket::TCP_DEFER_ACCEPT() } // 9;
+ defined(my $x = getsockopt($sock, IPPROTO_TCP, $var)) or die;
+ ok(unpack('i', $x) > 0, 'TCP_DEFER_ACCEPT set');
+};
+SKIP: {
+ skip 'SO_ACCEPTFILTER is FreeBSD-only', 1 if $^O ne 'freebsd';
+ if (system('kldstat -m accf_http >/dev/null') != 0) {
+ skip 'accf_http not loaded: kldload accf_http', 1;
+ }
+ require PublicInbox::Daemon;
+ my $var = PublicInbox::Daemon::SO_ACCEPTFILTER();
+ my $x = getsockopt($sock, SOL_SOCKET, $var);
+ like($x, qr/\Ahttpready\0+\z/, 'got httpready accf for HTTP');
+};
-1;
+done_testing;