summary |
shortlog |
log |
commit | commitdiff |
tree
raw |
patch |
inline | side by side (from parent 1:
0a80d0c)
Using a non-zero-length separator for `join' requires extra work
inside Perl. We can shove the cost of appending "\r\n" into the
`map' loop, instead. This speeds up the `join' operation.
The "deferred" log entry for a "LISTGROUP org.kernel.vger.linux-kernel"
command (with nearly 3.8 million messages) goes from ~3.96s to 3.86s
on my workstation.
my ($self, $beg, $end) = @_;
my $r = $self->{ng}->mm->msg_range($beg, $end, 'num');
scalar(@$r) or return;
my ($self, $beg, $end) = @_;
my $r = $self->{ng}->mm->msg_range($beg, $end, 'num');
scalar(@$r) or return;
- more($self, join("\r\n", map { $_->[0] } @$r));
+ $self->msg_more(join('', map { "$_->[0]\r\n" } @$r));
if (my $over = $ibx->over) {
my $msgs = $over->query_ts($ts, $$prev);
if (scalar @$msgs) {
if (my $over = $ibx->over) {
my $msgs = $over->query_ts($ts, $$prev);
if (scalar @$msgs) {
- more($self, '<' .
- join(">\r\n<",
- map { $_->{mid} } @$msgs ) .
- '>');
+ $self->msg_more(join('', map {
+ "<$_->{mid}>\r\n";
+ } @$msgs));
$$prev = $msgs->[-1]->{num};
return 1; # continue on current group
}
$$prev = $msgs->[-1]->{num};
return 1; # continue on current group
}
my ($self, $beg, $end) = @_;
my $r = $self->{ng}->mm->msg_range($beg, $end);
@$r or return;
my ($self, $beg, $end) = @_;
my $r = $self->{ng}->mm->msg_range($beg, $end);
@$r or return;
- more($self, join("\r\n", map { "$_->[0] <$_->[1]>" } @$r));
+ $self->msg_more(join('', map { "$_->[0] <$_->[1]>\r\n" } @$r));
my $msgs = $ng->over->query_xover($$beg, $end);
scalar(@$msgs) or return;
$$beg = $msgs->[-1]->{num} + 1;
my $msgs = $ng->over->query_xover($$beg, $end);
scalar(@$msgs) or return;
$$beg = $msgs->[-1]->{num} + 1;
- more($self, join("\r\n", map {
- "$_->{num} ".xref($self, $ng, $_);
+ $self->msg_more(join('', map {
+ "$_->{num} ".xref($self, $ng, $_) . "\r\n";
$smsg->{lines},
"Xref: " . xref($self, $ng, $smsg));
utf8::encode($s);
$smsg->{lines},
"Xref: " . xref($self, $ng, $smsg));
utf8::encode($s);
$smsg->{-orig_num} = $smsg->{num};
$smsg->{num} = 0;
}
$smsg->{-orig_num} = $smsg->{num};
$smsg->{num} = 0;
}
- more($self, over_line($self, $ng, $smsg));
+ $self->msg_more(over_line($self, $ng, $smsg));
'.';
} else {
cmd_xover($self, $range);
'.';
} else {
cmd_xover($self, $range);
my $nr = scalar @$msgs or return;
# OVERVIEW.FMT
my $nr = scalar @$msgs or return;
# OVERVIEW.FMT
- more($self, join("\r\n", map {
+ $self->msg_more(join('', map {
over_line($self, $ng, $_);
} @$msgs));
$$beg = $msgs->[-1]->{num} + 1;
over_line($self, $ng, $_);
} @$msgs));
$$beg = $msgs->[-1]->{num} + 1;