Instead of passing the prefix section and key separately, pass
them together as is commonly done with git-config(1) usage as
well as our ->get_all API. This inconsistency in the get_1 API
is a needless footgun and confused me a bit while working on
"lei up" the other week.
- my ($self, $pfx, $k) = @_;
- my $v = $self->{"$pfx.$k"} // return;
+ my ($self, $key) = @_;
+ my $v = $self->{$key};
- warn "W: $pfx.$k has multiple values, only using `$v->[-1]'\n";
+ warn "W: $key has multiple values, only using `$v->[-1]'\n";
}
for my $k (qw(filter inboxdir newsgroup replyto httpbackendmax feedmax
indexlevel indexsequentialshard boost)) {
}
for my $k (qw(filter inboxdir newsgroup replyto httpbackendmax feedmax
indexlevel indexsequentialshard boost)) {
- my $v = get_1($self, $pfx, $k) // next;
+ my $v = get_1($self, "$pfx.$k") // next;
}
my $es = PublicInbox::ExtSearch->new($d);
for my $k (qw(indexlevel indexsequentialshard)) {
}
my $es = PublicInbox::ExtSearch->new($d);
for my $k (qw(indexlevel indexsequentialshard)) {
- my $v = get_1($self, $pfx, $k) // next;
+ my $v = get_1($self, "$pfx.$k") // next;
$es->{$k} = $v;
}
for my $k (qw(coderepo hide url infourl)) {
$es->{$k} = $v;
}
for my $k (qw(coderepo hide url infourl)) {
require PublicInbox::LeiWatch;
$watches->{$url} //= PublicInbox::LeiWatch->new($url);
$seen{$url} = undef;
require PublicInbox::LeiWatch;
$watches->{$url} //= PublicInbox::LeiWatch->new($url);
$seen{$url} = undef;
- my $state = $cfg->get_1("watch.$url", 'state');
+ my $state = $cfg->get_1("watch.$url.state");
if (!watch_state_ok($state)) {
$lei->err("watch.$url.state=$state not supported");
next;
if (!watch_state_ok($state)) {
$lei->err("watch.$url.state=$state not supported");
next;
$lei->{opt}->{quiet} = 1;
eval { $lms->arg2folder($lei, [ $folder ]) };
return if $@;
$lei->{opt}->{quiet} = 1;
eval { $lms->arg2folder($lei, [ $folder ]) };
return if $@;
- my $state = $cfg->get_1("watch.$folder", 'state') // 'tag-rw';
+ my $state = $cfg->get_1("watch.$folder.state") // 'tag-rw';
return if $state eq 'pause';
return $lms->clear_src($folder, \$bn) if $new_cur eq '';
$lms->lms_pause;
return if $state eq 'pause';
return $lms->clear_src($folder, \$bn) if $new_cur eq '';
$lms->lms_pause;
$lei->{opt}->{$k} //= $v;
}
for my $k ($lss->BOOL_FIELDS, $lss->SINGLE_FIELDS) {
$lei->{opt}->{$k} //= $v;
}
for my $k ($lss->BOOL_FIELDS, $lss->SINGLE_FIELDS) {
- my $v = $lss->{-cfg}->get_1('lei.q', $k) // next;
+ my $v = $lss->{-cfg}->get_1("lei.q.$k") // next;
$lei->{opt}->{$k} //= $v;
}
my $o = $lei->{opt}->{output} // '';
$lei->{opt}->{$k} //= $v;
}
my $o = $lei->{opt}->{output} // '';