lib/PublicInbox/LeiP2q.pm | 10 +++++++--- t/lei-p2q.t | 3 +++ diff --git a/lib/PublicInbox/LeiP2q.pm b/lib/PublicInbox/LeiP2q.pm index d1dd125ebb858303e3740eaa2ccc1b6e80d1cf46..e7ddc852e492cfe500aa8b9ce31215f2bf498acb 100644 --- a/lib/PublicInbox/LeiP2q.pm +++ b/lib/PublicInbox/LeiP2q.pm @@ -12,6 +12,7 @@ use PublicInbox::MsgIter qw(msg_part_text); use PublicInbox::Git qw(git_unquote); use PublicInbox::Spawn qw(popen_rd); use URI::Escape qw(uri_escape_utf8); +my $FN = qr!((?:"?[^/\n]+/[^\r\n]+)|/dev/null)!; sub xphrase ($) { my ($s) = @_; @@ -23,7 +24,7 @@ # extract the longest phrase possible that Xapian can handle map { s/\A\s*//; s/\s+\z//; - /[\|=><,\sA-Z]/ && !m![\./:\\\@]! ? qq("$_") : $_; + m![^\./:\\\@\-\w]! ? qq("$_") : $_ ; } ($s =~ m!(\w[\|=><,\./:\\\@\-\w\s]+)!g); } @@ -40,7 +41,7 @@ if ($in_diff && s/^ //) { # diff context push @{$lei->{qterms}->{dfctx}}, xphrase($_); } elsif (/^-- $/) { # email signature begins $in_diff = undef; - } elsif (m!^diff --git "?[^/]+/.+ "?[^/]+/.+\z!) { + } elsif (m!^diff --git $FN $FN!) { # wait until "---" and "+++" to capture filenames $in_diff = 1; } elsif (/^index ([a-f0-9]+)\.\.([a-f0-9]+)\b/) { @@ -48,13 +49,16 @@ my ($oa, $ob) = ($1, $2); push @{$lei->{qterms}->{dfpre}}, $oa; push @{$lei->{qterms}->{dfpost}}, $ob; # who uses dfblob? - } elsif (m!^(?:---|\+{3}) ("?[^/]+/.+)!) { + } elsif (m!^(?:---|\+{3}) ($FN)!) { + next if $1 eq '/dev/null'; my $fn = (split(m!/!, git_unquote($1.''), 2))[1]; push @{$lei->{qterms}->{dfn}}, xphrase($fn); } elsif ($in_diff && s/^\+//) { # diff added push @{$lei->{qterms}->{dfb}}, xphrase($_); } elsif ($in_diff && s/^-//) { # diff removed push @{$lei->{qterms}->{dfa}}, xphrase($_); + } elsif (/^@@ (?:\S+) (?:\S+) @@\s*$/) { + # traditional diff w/o -p } elsif (/^@@ (?:\S+) (?:\S+) @@\s*(\S+.*)/) { push @{$lei->{qterms}->{dfhh}}, xphrase($1); } elsif (/^(?:dis)similarity index/ || diff --git a/t/lei-p2q.t b/t/lei-p2q.t index 1a2c2e4f2d201ad726502a59878964277594b69f..87cf9fa7d6d9fcad15097037f5cf8610e72a8f3f 100644 --- a/t/lei-p2q.t +++ b/t/lei-p2q.t @@ -25,5 +25,8 @@ "dfpost:6e006fd73b1 OR " . "dfpost:6e006fd73b OR " . "dfpost:6e006fd73\n", '3-byte chop'); + + lei_ok(qw(p2q t/data/message_embed.eml --want=dfb)); + like($lei_out, qr/\bdfb:\S+/, 'got dfb off /dev/null file'); }); done_testing;