From: Matt Joiner Date: Sun, 11 Oct 2020 01:57:33 +0000 (+1100) Subject: Panic on bad piece per resource chunk names X-Git-Tag: v1.18.0~13 X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=00ac333ea2d00aa150a6e8ad8a160254715f5441;p=btrtrc.git Panic on bad piece per resource chunk names This was masking a bug in a coming sqlite storage implementation. Maybe it could be relaxed to checking for no filepath.Dir in the future. --- diff --git a/storage/piece_resource.go b/storage/piece_resource.go index 201d3f37..86a081f2 100644 --- a/storage/piece_resource.go +++ b/storage/piece_resource.go @@ -123,7 +123,7 @@ func (s piecePerResourcePiece) getChunks() (chunks chunks) { for _, n := range names { offset, err := strconv.ParseInt(n, 10, 64) if err != nil { - continue + panic(err) } i, err := s.rp.NewInstance(path.Join(s.incompleteDirPath(), n)) if err != nil {